Re: [PATCH] Add Rage

[Ricardo Wurmus <rekado@elephly.net>]

Hi Daniel,

as I wrote in a previous email the commit message should follow the
format shown in other messages.  Take a look at the output of “git log”.

Your patch adds a lot more than just “rage”.  Also the copyright line
seems to be wrong.  Did you really intend to submit a patch with copies
of “efl”, “elementary”, “evas-generic-loaders”, and
“emotion-generic-players” in addition to “rage”?  If not, please do not
include them in your commit.

Please submit one separate patch for every single package definition you
add.

I also think that “rage” better not be in its own module.  How about
adding it to “enlightenment.scm” or “audio.scm” or similar?

Please also run “guix lint rage” to let Guix tell you a couple of things
that can be improved about your package.

~~ Ricardo