Re: [PATCH] Add gerbv.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> From e992f3d52f99219f25f00d1917ca6f83f9e805f3 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 31 Aug 2015 08:46:12 +0200
> Subject: [PATCH 1/2] gnu: Add po4a.
>
> * gnu/packages/gettext.scm (po4a): New variable.

[...]

> +            (substitute* "Po4aBuilder.pm"
> +              ;; By default it tries to install into perl's manpath.
> +              (("my \\$mandir = .*$")
> +               (string-append "my $mandir = \"" (assoc-ref outputs "out")
> +                              "/share/man\";\n"))
> +              ;; Use local docbook XSL
> +              (((string-append "--nonet http://docbook.sourceforge.net/"
> +                                "release/xsl/current"
> +                                "/manpages/docbook.xsl"))

Rather make it a string literal, using backslashes for newlines, but...

> +               (string-append "--nonet "
> +                              (assoc-ref inputs "docbook-xsl")
> +                              ;; TODO: replace version string
> +                              "/xml/xsl/docbook-xsl-"  "1.78.1"
> +                              "/manpages/docbook.xsl")))

... can this be avoided altogether by adding libxml2 as an input (which
sets $XML_CATALOG_FILES as a side-effect)?

Otherwise LGTM.

> From 87f3d5df4cb7672e6dcdaa1e4e2b7fc59ff37e11 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Mon, 31 Aug 2015 08:47:09 +0200
> Subject: [PATCH 2/2] gnu: Add gerbv.
>
> * gnu/packages/engineering.scm (gerbv): New variable.

[...]

> +            ;; Build rules contain references to Russian translation, but the
> +            ;; needed files are missing; see
> +            ;; http://sourceforge.net/p/gerbv/bugs/174/
> +            (delete-file "po/LINGUAS")
> +            (substitute* "man/Makefile.am"
> +              (("PO_FILES= gerbv.ru.1.in.po") "")
> +              (("man_MANS = gerbv.1 gerbv.ru.1") "man_MANS = gerbv.1"))
> +            (zero? (system* "autoreconf" "-vfi")))))))

Could you modify Makefile.in instead?  That would hopefully allow us to
remove the dependency on the autotools.

> +     "Gerbv is a Gerber file (RS-274X only) viewer.  Gerbv lets you load

What about giving a bit more context, along the lines of:

  Gerbv is a viewer for files in the Gerber format (RS-274X only), which
  is commonly used to represent printed circuit board (PCB) layouts.

?

Otherwise, LGTM.

Thanks,
Ludo’.