From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH 3/7] gnu: efl: Update to 1.15.1.
Date: Thu, 10 Sep 2015 18:58:50 +0200
Message-ID: <87r3m6p5x1.fsf@openmailbox.org>
References: <1441892864-20745-1-git-send-email-efraim@flashner.co.il>
	<1441892864-20745-4-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Za5Bk-0003N5-5v
	for guix-devel@gnu.org; Thu, 10 Sep 2015 12:59:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Za5Bg-0002ih-2f
	for guix-devel@gnu.org; Thu, 10 Sep 2015 12:59:08 -0400
Received: from smtp24.openmailbox.org ([62.4.1.58]:46581)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Za5Bf-0002i4-Tm
	for guix-devel@gnu.org; Thu, 10 Sep 2015 12:59:04 -0400
In-Reply-To: <1441892864-20745-4-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Thu, 10 Sep 2015 16:47:40 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> writes:

> * gnu/packages/enlightenment.scm (efl): Update to 1.15.1.
>   Align package to 80 width columns.
    ^^^
    This is not necessary to notify indentation changes in commit
    messages.

> ---
>  gnu/packages/enlightenment.scm | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
> index 2470d1e..6b1257a 100644
> --- a/gnu/packages/enlightenment.scm
> +++ b/gnu/packages/enlightenment.scm
> @@ -51,14 +51,14 @@
>  (define-public efl
>    (package
>      (name "efl")
> -    (version "1.14.2")
> +    (version "1.15.1")
>      (source (origin
> -              (method url-fetch)
> -              (uri (string-append
> -                    "https://download.enlightenment.org/rel/libs/efl/efl-"
> -                    version ".tar.xz"))
> -              (sha256
> -               (base32 "0kg51v63ljq1z4dj65aiyxaqhq54gkl4hx53ifwbci6ihammandr"))))
> +             (method url-fetch)
> +             (uri (string-append
> +                   "https://download.enlightenment.org/rel/libs/efl/efl-"
> +                   version ".tar.xz"))
> +             (sha256
> +              (base32 "1n2l2n09lys5dph9lrnsv5z3qbgzp7bi0vidal2fvy18hflbbvsn"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> @@ -127,7 +127,8 @@
>  for Enlightenment.  Libraries covers data serialization, wide support for
>  graphics rendering, UI layout and themes, interaction with OS, access to
>  removable devices or support for multimedia.")
> -    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ; different parts under different licenses
> +    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) 
> +				;;; different parts under different licenses

There is a trailing white space here. ";;;" is not adapted for this type of
comment I would suggest this

    ;; Different parts are under different licenses.
    (license (list license:bsd-2 license:lgpl2.1 license:zlib))))

Can you send the updated patch?

--
Mathieu Lirzin