From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] edit: Friendlier error message.
Date: Sat, 07 Nov 2015 12:06:49 +0100
Message-ID: <87r3k26pbq.fsf@gnu.org>
References: <1446676935-11602-1-git-send-email-benno@bmevers.de>
	<874mh0900c.fsf@gnu.org> <20151107032513.GC5225@debian.upm.edu.my>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zv1Kh-0004of-Eo
	for guix-devel@gnu.org; Sat, 07 Nov 2015 06:06:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zv1Ke-0002aL-9c
	for guix-devel@gnu.org; Sat, 07 Nov 2015 06:06:55 -0500
In-Reply-To: <20151107032513.GC5225@debian.upm.edu.my> (Andreas Enge's message
	of "Sat, 7 Nov 2015 04:25:13 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org, benno@bmevers.de

Andreas Enge <andreas@enge.fr> skribis:

> On Thu, Nov 05, 2015 at 12:08:35PM +0100, Ludovic Court=C3=A8s wrote:
>> > +    (unless (search-path (parse-path (getenv "PATH")) (%editor))
>> > +      (leave (_ "Couldn't find editor '~a'. Please check $EDITOR and =
$PATH.")
>> > +             (%editor)))
>
> An additional, heterodox suggestion: Maybe also test for $VISUAL.

AIUI, $VISUAL is for visualizing files, not for editing, no?

Ludo=E2=80=99.