all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Jeff Mickey <j@codemac.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH, WIP] new variable: redshift
Date: Wed, 25 Nov 2015 13:47:46 +0100	[thread overview]
Message-ID: <87r3jei6tp.fsf@gnu.org> (raw)
In-Reply-To: <877fl7crsl.fsf@codemac.net> (Jeff Mickey's message of "Tue, 24 Nov 2015 07:59:06 -0800")

Jeff Mickey <j@codemac.net> skribis:

> Don't know what others think, but we should probably also package
> redshift-gtk if we're gonna include redshift. Mine has a bug where icons
> don't show up so I didn't push it, but see here for what I use locally:
>
> https://github.com/codemac/guix-pkgs/blob/master/src/codemac/packages/redshift.scm

I see your redshift package is also slightly more elaborate.  Would you
like to submit it (or Florian can incorporate the differences)?  Here
are some comments:

> +    (synopsis
> +     "Adjusts the color temperature of your screen
> + according to your surroundings")

Rather “Adjust your screen's color temperature”.

> +    (description
> +     "This may help your eyes hurt less if you are working
> +in front of the screen at night.")

What about:

  “Redshift adjust your screen's color temperature according to your
  environment.  This may help make your eyes hurt less, for instance
  when working in front of the screen at night.”

?

> +    (license license:gpl3)))

The source file headers carry the “or later” clause, so this should be
‘gplv3+’.

Thanks in advance!

Ludo’.

  parent reply	other threads:[~2015-11-25 12:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  8:28 [PATCH, WIP] new variable: redshift Florian Paul Schmidt
2015-11-24  8:58 ` Florian Paul Schmidt
2015-11-24  9:23   ` Florian Paul Schmidt
2015-11-24 15:59     ` Jeff Mickey
2015-11-25 11:28       ` Florian Paul Schmidt
2015-11-25 12:41       ` Ludovic Courtès
2015-11-25 12:47       ` Ludovic Courtès [this message]
2015-11-25 13:10         ` Andreas Enge
2015-11-25 16:58         ` Florian Paul Schmidt
2015-11-24  9:02 ` Florian Paul Schmidt
2015-12-10  8:04 ` [PATCH, WIP, v2] " Florian Paul Schmidt
2015-12-13 23:41   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3jei6tp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=j@codemac.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.