From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH 2/3] system: Add /etc/environment. Date: Sat, 05 Dec 2015 10:55:14 +0800 Message-ID: <87r3j1vc31.fsf@member.fsf.org> References: <1449063511-689-1-git-send-email-iyzsong@gmail.com> <1449063511-689-2-git-send-email-iyzsong@gmail.com> <87io4ejnb0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a530v-0005IX-Hk for guix-devel@gnu.org; Fri, 04 Dec 2015 21:55:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a530q-0002tj-Kv for guix-devel@gnu.org; Fri, 04 Dec 2015 21:55:57 -0500 In-Reply-To: <87io4ejnb0.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 04 Dec 2015 15:33:39 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > >> * gnu/system.scm: (operating-system-environment-variables): New procedur= e. >> Adapted and moved environment variables from /etc/profile. >> (operating-system-etc-service): Adjust accordingly. >> (essential-services): Add an instance of SESSION-ENVIRONMENT-SERVICE-TYP= E. > > This looks good, but it must be applied after patch 3/3. Otherwise, > we=E2=80=99d end up with a system that has an empty /etc/profile and an > /etc/environment file that is not honored. Sure, pushed, thanks for review!