From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: swh-plugins-lv2: New variable [WIP] v2
Date: Wed, 09 Dec 2015 21:56:37 +0100 [thread overview]
Message-ID: <87r3ivl4sa.fsf@gnu.org> (raw)
In-Reply-To: <20151209200405.GA19108@jasmine> (Leo Famulari's message of "Wed, 9 Dec 2015 15:04:05 -0500")
Leo Famulari <leo@famulari.name> skribis:
> On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote:
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>> > Ricardo Wurmus <rekado@elephly.net> writes:
>> >
>> >>> +(define-public swh-plugins-lv2
>> >>> + (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
>> >>
>> >> We usually don’t use full commit hashes. You could probably trim it to
>> >> the first six characters or so.
>> >
>> > I would recommend using at least 10 characters, maybe more. We should
>> > use enough characters to ensure that the commit id remains unique for as
>> > long as this package version remains in use -- keeping in mind that for
>> > purposes of reproducing old experiments, someone might try to build this
>> > package+version several years from now.
>>
>> I sympathize with this. I would think 10 digits is more than needed,
>> though: With 6 hex digits, it takes on average 16^6 = 16M commits before
>> the 6-digit ID is ambiguous, and with 8 hex digits that goes to
>> 4 billion commits (Emacs has around 123,000 commits as an example.)
>>
>> But anyway, to be super-safe, we could use the full SHA1 in the URL, but
>> strip it in the ‘version’ field so that it remains readable.
>>
>> Thoughts?
>
> I don't see a reason to not use the full hash. I know the odds but why
> discard the information? We can't complain about it being ugly given the
> aesthetics of /gnu/store. ;)
The ‘version’ field shows up in user interfaces, where aesthetics do
matter IMO. WDYT?
(In some cases, it’s also a good way to avoid hitting limitations on the
shebang length and on the AF_UNIX socket name length.)
Ludo’.
next prev parent reply other threads:[~2015-12-09 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 22:44 swh-plugins-lv2: New variable [WIP] Florian Paul Schmidt
2015-12-06 22:49 ` swh-plugins-lv2: New variable [WIP] v2 Florian Paul Schmidt
2015-12-07 21:17 ` Ricardo Wurmus
2015-12-07 21:41 ` Florian Paul Schmidt
2015-12-07 22:03 ` Ricardo Wurmus
2015-12-08 8:54 ` Ludovic Courtès
2015-12-08 4:13 ` Mark H Weaver
2015-12-08 8:52 ` Ludovic Courtès
2015-12-09 20:04 ` Leo Famulari
2015-12-09 20:56 ` Ludovic Courtès [this message]
2015-12-09 21:24 ` Leo Famulari
2015-12-08 4:35 ` Leo Famulari
2015-12-10 14:15 ` swh-plugins-lv2: New variable [WIP, v2] Florian Paul Schmidt
2016-11-04 11:12 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3ivl4sa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.