From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 3/7] emacs: Add 'guix-browse-license-url' command. Date: Mon, 25 Jan 2016 22:18:42 +0300 Message-ID: <87r3h579il.fsf@gmail.com> References: <1453450775-594-1-git-send-email-alezost@gmail.com> <1453450775-594-4-git-send-email-alezost@gmail.com> <8737toxlqp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNmf1-0008Ga-NM for guix-devel@gnu.org; Mon, 25 Jan 2016 14:18:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNmey-0004Id-Dx for guix-devel@gnu.org; Mon, 25 Jan 2016 14:18:47 -0500 In-Reply-To: <8737toxlqp.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 23 Jan 2016 18:13:18 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-01-23 20:13 +0300) wrote: > Alex Kost skribis: > >> * emacs/guix-main.scm (license-names, license-name->license) >> (license-name->uri): New procedures. >> * emacs/guix-read.el (guix-license-names, guix-read-license-name): New >> procedures. >> * emacs/guix-license.el: New file. >> * emacs.am (ELFILES): Add it. > > [...] > >> +;;; Licenses > > I=E2=80=99d do: > > (define %licenses > (delay (module-map thing from previous message=E2=80=A6))) > >> +(define (license-names) >> + "Return a list of names of available licenses." >> + (map license-name %licenses)) > > So here it=E2=80=99d become: (force %licenses). > > Other than that, LGTM! I used delay/force and "(filter license? (module-map =E2=80=A6))" advice fr= om the other message and pushed this patchset. Thank you for your very useful and informative comments! --=20 Alex