From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add gtklick.
Date: Sat, 27 Feb 2016 00:38:17 +0100
Message-ID: <87r3fzxct2.fsf@gnu.org>
References: <87a8moeylu.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aZRxo-0007Eh-P3
	for guix-devel@gnu.org; Fri, 26 Feb 2016 18:38:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aZRxk-00070P-OX
	for guix-devel@gnu.org; Fri, 26 Feb 2016 18:38:24 -0500
In-Reply-To: <87a8moeylu.fsf@elephly.net> (Ricardo Wurmus's message of "Fri,
	26 Feb 2016 08:10:05 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 76cb9cb91b76f4bb723030d3d5a63238cdf98e20 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 25 Feb 2016 09:45:05 +0100
> Subject: [PATCH 1/3] gnu: Add pyliblo.
>
> * gnu/packages/audio.scm (python-pyliblo, python2-pyliblo): New
>   variables.

[...]

> +    (home-page "http://das.nasophon.de/pyliblo/")
> +    (synopsis "Python bindings for the liblo OSC library")

Maybe just =E2=80=9CPython bindings for liblo=E2=80=9D, and=E2=80=A6

> +    (description
> +     "Pyliblo is a Python wrapper for the liblo OSC library.  It supports

=E2=80=9C=E2=80=A6 for the liblo Open Sound Control (OSC) library.=E2=80=9D

Otherwise LGTM.

> From 1dc15ad2e3776904ff8b838add00d66d9671b48a Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 26 Feb 2016 08:05:40 +0100
> Subject: [PATCH 2/3] gnu: python2-pygtk: Add libglade to inputs.
>
> * gnu/packages/gtk.scm (python2-pygtk)[inputs]: Add "libglade".

OK.

> From cfda70fdd6448980df9ba4c22894198366a2846d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 25 Feb 2016 09:46:01 +0100
> Subject: [PATCH 3/3] gnu: Add gtklick.
>
> * gnu/packages/music.scm (gtklick): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'build 'add-sitedirs
> +           ;; .pth files are not automatically interpreted unless the
> +           ;; directories containing them are added as "sites".  The dir=
ectories
> +           ;; are then added to those in the PYTHONPATH.  This is requir=
ed for
> +           ;; the operation of pygtk.

Strangely, other users of pygtk don=E2=80=99t do that, no?  What=E2=80=99s =
special here?

> +           (lambda _
> +             (substitute* "gtklick/gtklick.py"
> +               (("import pygtk")
> +                "import pygtk, site, sys
> +for path in [path for path in sys.path if 'site-packages' in path]: site=
.addsitedir(path)"))))

I guess it=E2=80=99s a list comprehension, but I=E2=80=99m a bit confused b=
y the syntax
and the various =E2=80=98path=E2=80=99.  Oh well.  :-)

Thanks!

Ludo=E2=80=99.