From: ludo@gnu.org (Ludovic Courtès)
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] environment: container: Do not remount network files as read-only.
Date: Sat, 26 Mar 2016 19:43:48 +0100 [thread overview]
Message-ID: <87r3exyt97.fsf@gnu.org> (raw)
In-Reply-To: <CAJ=RwfZCEpOkUJyVYZNbM3_rqEdVh3yshFgL_odFXZcLU+MQVw@mail.gmail.com> (David Thompson's message of "Sat, 26 Mar 2016 10:06:58 -0400")
[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]
"Thompson, David" <dthompson2@worcester.edu> skribis:
> On Fri, Mar 18, 2016 at 4:51 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> "Thompson, David" <dthompson2@worcester.edu> skribis:
>>
>>> I noticed that 'guix environment --container --network' didn't work on
>>> an Ubuntu machine I was on, and the culprit was remounting things like
>>> /etc/resolv.conf read-only after the initial bind mount.
>>
>> [...]
>>
>>> (file-system-mapping
>>> (source file)
>>> (target file)
>>> - (writable? #f))))
>>> + ;; An unpriviliged user might not
>>> + ;; be able to remount
>>> + ;; /etc/resolv.conf as read-only,
>>> + ;; so we say that it is writable
>>> + ;; here, even though in practice
>>> + ;; it is not.
>>> + (writable? #t))))
>>> %network-configuration-files)
>>
>> Not sure I understand: why would bind-mounting /etc/resolv.conf
>> read-only fail?
>
> I haven't figured out the exact reason yet, but here's a strace
> snippet as proof:
>
> [pid 11334] mount("/etc/resolv.conf",
> "/tmp/guix-directory.Rc4nc6//etc/resolv.conf", 0x23da000,
> MS_RDONLY|MS_BIND, NULL) = 0
> [pid 11334] mount("/etc/resolv.conf",
> "/tmp/guix-directory.Rc4nc6//etc/resolv.conf", 0x23e4080,
> MS_RDONLY|MS_REMOUNT|MS_BIND, NULL) = -1 EPERM (Operation not
> permitted)
>
> Another Ubuntu user was able to reproduce this as well.
Looking at the resolvconf man page that Drew mentioned, it seems that
/etc/resolv.conf is a symlink when resolvconf is in used, right?
If yes, does this make a difference:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 555 bytes --]
diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 58ccf59..a329eeb 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -378,7 +378,7 @@ corresponds to the symbols listed in FLAGS."
(define (regular-file? file-name)
"Return #t if FILE-NAME is a regular file."
- (eq? (stat:type (stat file-name)) 'regular))
+ (memq (stat:type (stat file-name)) '(regular symlink)))
(define* (mount-file-system spec #:key (root "/root"))
"Mount the file system described by SPEC under ROOT. SPEC must have the
[-- Attachment #3: Type: text/plain, Size: 247 bytes --]
It may be that the result after this is that you get /etc/resolv.conf in
the container, but it’s a dangling symlink. But isn’t it the case
already with the patch you propose?
Thanks for finding all these curiosities. :-)
Ludo’.
next prev parent reply other threads:[~2016-03-26 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 18:32 [PATCH] environment: container: Do not remount network files as read-only Thompson, David
2016-03-18 20:51 ` Ludovic Courtès
2016-03-26 14:06 ` Thompson, David
2016-03-26 16:29 ` Drew C
2016-03-26 16:49 ` Thompson, David
2016-03-26 16:59 ` Drew C
2016-03-26 18:43 ` Ludovic Courtès [this message]
2016-03-26 18:54 ` Drew C
2016-03-26 19:23 ` Thompson, David
2016-03-27 17:43 ` Ludovic Courtès
2016-03-28 0:32 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3exyt97.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.