From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix
Date: Thu, 26 May 2016 22:13:20 +0200
Message-ID: <87r3copogv.fsf@gnu.org>
References: <CAKKYfmHtwMd-HvYqdrKaYJ6kPQoc0b-71paW7zg+F0y5-4CPUw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1b61er-0007rI-SW
	for guix-devel@gnu.org; Thu, 26 May 2016 16:13:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1b61en-0008QZ-Ip
	for guix-devel@gnu.org; Thu, 26 May 2016 16:13:28 -0400
In-reply-to: <CAKKYfmHtwMd-HvYqdrKaYJ6kPQoc0b-71paW7zg+F0y5-4CPUw@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Dennis Mungai <dmngaie@gmail.com>
Cc: guix-devel@gnu.org

Hello Dennis,

Welcome and thank you for the patch.

Dennis Mungai writes:

> +(define-public llvm-3.8
> +  (package (inherit llvm)
> +    (version "3.8.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://llvm.org/releases/"
> +                           version "/llvm-" version ".src.tar.xz"))
> +       (sha256
> +        (base32
> +         "0ikfq0gxac8xpvxj23l4hk8f12ydx48fljgrz1gl9xp0ks704nsm"))))
> +    (native-inputs
> +     `(("python" ,python-wrapper)
> +       ("perl"   ,perl)
> +       ("libffi" ,libffi)
> +       ("zlib" ,zlib)))

One space between the string and the unquote is enough.

> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_SKIP_BUILD_RPATH=FALSE"
> +                           "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE"
> +                           "-DLLVM_ENABLE_PIC=ON"
> +                           ;"-DLLVM_ENABLE_RTTI=ON"
> +                           "-DLLVM_ENABLE_WERROR=OFF"
> +                           ;;"-DLLVM_REQUIRES_RTTI=ON"

Could you remove the options you commented out?

> +                           )))))

These should be positioned directly after "-DLLVM_ENABLE_WERROR=OFF".

> +
> +(define-public clang-runtime-3.8
> +  (clang-runtime-from-llvm
> +   llvm-3.8
> +   "1c2nkp9563873ffz22qmhc0wakgj428pch8rmhym8agjamz3ily8"))
> +
> +(define-public clang-3.8
> +  (clang-from-llvm llvm-3.8 clang-runtime-3.8
> +                   "1ybcac8hlr9vl3wg8s4v6cp0c0qgqnwprsv85lihbkq3vqv94504"))
> -- 
> 2.7.4

Thank you,
Roel Janssen