From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/3] profiles: Add fonts-dir-file hook. Date: Tue, 05 Jul 2016 16:31:03 +0200 Message-ID: <87r3b8w40o.fsf@gnu.org> References: <20160701092730.2265-1-alezost@gmail.com> <20160701092730.2265-3-alezost@gmail.com> <87fursf6rf.fsf@gnu.org> <87lh1jalvm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKRNY-0006By-E4 for guix-devel@gnu.org; Tue, 05 Jul 2016 10:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKRNS-0004OL-TE for guix-devel@gnu.org; Tue, 05 Jul 2016 10:31:11 -0400 In-Reply-To: <87lh1jalvm.fsf@gmail.com> (Alex Kost's message of "Sat, 02 Jul 2016 22:19:25 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Ludovic Court=C3=A8s (2016-07-02 17:34 +0300) wrote: > >> Alex Kost skribis: >> >>> * guix/profiles.scm (fonts-dir-file): New procedure. >>> (%default-profile-hooks): Add it. >> >> [...] >> >> A potential problem with this hook is that it pulls mkfontscale and >> mkfontdir regardless of whether they are needed; I can=E2=80=99t really = think of >> a way to avoid it though. > > Yes, I also don't like it. We have the same problem with > 'info-file-dir' hook: it always pulls texinfo and gzip, but not all > profiles include info manuals. Yes, but I thought it was OK to make these mandatory dependencies. The closure of mkfontscale + mkfontdir is small; it=E2=80=99s slightly anno= ying for someone building from source because you have to build a few X11 libraries, but it=E2=80=99s not that much either (=E2=80=98guix graph=E2=80= =99 shows just a few boxes.) So this hook is probably fine, after all. What do people think? >> Also, how does it relate to this: >> >> commit bf9655f57d2442d56661594b80f6d0031ca0ae73 >> Author: Eric Bavier >> Date: Mon Oct 19 06:44:23 2015 -0500 >> >> font-alias: Install dummy fonts.dir files. >> >> * gnu/packages/xorg.scm (font-alias)[arguments]: New 'install-font= s-dir' >> phase. >> >> ? > > It doesn't relate at all. Good. :-) > This hook generates "fonts.dir" only for "share/fonts/truetype" > directory. Directories with X fonts are not touched, because all > sub-directories of "share/fonts/X11" already contain "fonts.dir" files > (font-adobe75dpi, font-misc-misc and other X font packages install > "fonts.dir"). > > 'font-alias' package does not contain fonts.dir file because it doesn't > make sense: this package does not provide any font. It just installs > "fonts.alias" files inside "share/fonts/X11/{75dpi,100dpi,cyrillic,misc}" > directories. Eric made this commit for one particular case: to make it > possible to use font aliases in the default X server configuration > ('xorg-configuration-file' in (gnu services xorg) module). > > Just to mention, I think we shouldn't modify 'font-alias' package as it > leads to a bug , and should do some other > workaround. I have 2 ideas (not sure if they make any sense): > > 1) To add a special package (font-alias-with-fonts.dir) that will be used > in 'xorg-configuration-file'. > > 2) To do 'union-build' on packages with X fonts and aliases and to use it > in the X config. With this, we can revert that Eric's commit, and > everything should just work (I mean the X config will work and the bug > will be fixed). Could you discuss it with 22100@debbugs.gnu.org and Cc: Eric? I=E2=80=99m = not sure I=E2=80=99m competent enough to comment, so I=E2=80=99d rather let you= and Eric figure out what needs to be done. :-) Thanks! Ludo=E2=80=99.