Guile question ... Re: [PATCH 07/11] gnu: ncurses: support mingw.

[Jan Nieuwenhuizen <janneke@gnu.org>]

Ricardo Wurmus writes:

> The command “guix refresh -l package-name” gives you a very rough list
> of packages (on the same architecture) that would be affected by an
> update to “package-name”.  This isn’t always correct, but in the case of
> ncurses it shows at least that a lot of packages are affected:
>
>     guix refresh -l ncurses
>     …
>     Building the following 1018 packages would ensure 2616 dependent
>     packages are rebuilt: …

Thanks!

I found why my ncurses still triggers rebuilds: that was in my fixes
that I added on top of Mark's patch, adding necessary MinGW configure
flags

    `(#:configure-flags
      `(
       ...
       ;; MinGW: Provide termcap api, created for the MinGW port.
       ,,@(if (target-mingw?) '("--enable-term-driver") '())
       )

While this `works' build-wise, it still modifies configure-flags when
not target-mingw?.

That is solved technically by doing it like so

    `(#:configure-flags
      ,(cons*
        'quasiquote
        `("--with-shared" "--without-debug" "--enable-widec"

          ;; By default headers land in an `ncursesw' subdir, which is not
          ;; what users expect.
          ,(list 'unquote '(string-append "--includedir=" (assoc-ref %outputs "out")
                                          "/include"))
          "--enable-overwrite"       ;really honor --includedir

          ;; Make sure programs like 'tic', 'reset', and 'clear' have a
          ;; correct RUNPATH.
          ,(list 'unquote '(string-append "LDFLAGS=-Wl,-rpath=" (assoc-ref %outputs "out")
                                          "/lib")))
        ;; MinGW: Provide termcap api, created for the MinGW port.
        (if (target-mingw?) '("--enable-term-driver") '()))

...is there an easier/cleaner way, this looks overly complicated.

Greetings,
Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl