From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 09/24] gnu: freedesktop: Add wayland-protocols.
Date: Tue, 16 Aug 2016 23:02:43 +0300
Message-ID: <87r39oiisc.fsf@gmail.com>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-9-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkZV-00033B-Rc
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:02:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkZP-0000Oc-Tg
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:02:48 -0400
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkZP-0000OY-Mp
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:02:43 -0400
Received: by mail-wm0-x242.google.com with SMTP id i5so18212382wmg.2
	for <guix-devel@gnu.org>; Tue, 16 Aug 2016 13:02:43 -0700 (PDT)
In-Reply-To: <20160816183938.22794-9-david@craven.ch> (David Craven's message
	of "Tue, 16 Aug 2016 20:39:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/freedesktop.scm (wayland-protocols): New variable.
> ---
>  gnu/packages/freedesktop.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index 0262d0a..a24d8fa 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -295,6 +295,28 @@ application, or a wayland client itself.  The clients can be traditional
>  applications, X servers (rootless or fullscreen) or other display servers.")
>      (license license:x11)))
>  
> +(define-public wayland-protocols
> +  (package
> +    (name "wayland-protocols")
> +    (version "1.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                "https://wayland.freedesktop.org/releases/"
> +                "wayland-protocols-" version ".tar.xz"))

Please fix indentation here (and in other packages)

> +              (sha256
> +               (base32
> +                "0wpm7mz7ww6nn3vrgz7a9iyk7mk6za73wnq0n54lzl8yq8irljh1"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("wayland" ,wayland)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (synopsis "Wayland protocols")
> +    (description "Contains Xml definitions of the wayland protocols.")

Descriptions should contain full sentences, like:

"This package contains XML definitions of the Wayland protocols."

> +    (home-page "https://wayland.freedesktop.org")
> +    (license license:expat)))
> +
>  (define-public exempi
>    (package
>      (name "exempi")

-- 
Alex