[PATCH] gnu: Add ola.

[PATCH] gnu: Add ola.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hello Guix,

> Date: Wed, 03 Aug 2016 09:14:09 -0400
> From: John J Foerch <jjfoerch@earthlink.net>
> 
> Hi, I have a favor to ask of anybody in the guix community - is there
> anybody who would be willing to finish this package for me, since I
> can't build and test it?  This is a library that I need to use, but
> maybe the only way that I can use it (until I upgrade my computer) will
> be to install it as a substitute.
> 
> Or are there any other suggestions for how I can build this myself?


I attached the patch with some modifications for your review.
I compiled and installed the ola package correctly.

John, how I can make a real test to see if it works?


Thanks

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-ola.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-ola.patch, Size: 3335 bytes --]

From 562f3f6d4446fa68c21f1c42c0f39bf2ac145935 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 3 Aug 2016 21:36:52 -0500
Subject: [PATCH] gnu: Add ola.
	 
	* gnu/packages/ola.scm (ola): New variable.

---
 gnu/packages/ola.scm | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644 gnu/packages/ola.scm

diff --git a/gnu/packages/ola.scm b/gnu/packages/ola.scm
new file mode 100644
index 0000000..826c989
--- /dev/null
+++ b/gnu/packages/ola.scm
@@ -0,1 +1,66 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages ola)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf))
+
+(define-public ola
+  (package
+    (name "ola")
+    (version "0.10.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/OpenLightingProject/ola/releases/download/"
+                    version "/ola-" version ".tar.gz"))
+              (sha256
+               (base32
+                "09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("bison" ,bison)
+       ("cppunit" ,cppunit)
+       ("flex" ,flex)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libuuid" ,util-linux)
+       ("protobuf" ,protobuf)
+       ("zlib" ,zlib)))
+    (arguments
+     `(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases %standard-phases))
+    (synopsis "Framework for controlling entertainment lighting equipment")
+    (description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+    (home-page "https://www.openlighting.org/ola")
+    (license license:lgpl2.1+)))
-- 
2.6.3

Re: [PATCH] gnu: Add ola.

[John J Foerch]

rennes@openmailbox.org writes:

> Hello Guix,
>
>> Date: Wed, 03 Aug 2016 09:14:09 -0400
>> From: John J Foerch <jjfoerch@earthlink.net>
>>
>> Hi, I have a favor to ask of anybody in the guix community - is there
>> anybody who would be willing to finish this package for me, since I
>> can't build and test it?  This is a library that I need to use, but
>> maybe the only way that I can use it (until I upgrade my computer) will
>> be to install it as a substitute.
>>
>> Or are there any other suggestions for how I can build this myself?
>
>
> I attached the patch with some modifications for your review.
> I compiled and installed the ola package correctly.
>
> John, how I can make a real test to see if it works?
>
>
> Thanks

Hi Rene,

Thank you so much for doing this.  If 'make check' succeeds, those are
the main tests, but to check installation, I would look for the
following programs being installed:

    ola                   ola_e131        ola_plugin_state   ola_rdm_set
    ola_set_priority      ola_trigger     ola_uni_name       ola_artnet
    ola_dmxconsole        ola_patch       ola_rdm_discover   ola_recorder
    ola_streaming_client  ola_uni_info    ola_uni_stats      olad
    ola_dmxmonitor        ola_plugin_info ola_rdm_get        ola_set_dmx
    ola_timecode          ola_uni_merge   ola_usbpro         ola_dev_info

These are the programs installed by the Debian ola package, and I don't
know what packaging options might have affected which were installed,
but the list should be more or less the same.

To start the ola daemon and generate a config:

    olad -c ~/my-ola

This should start a web service on port 9090, so you can point a web
browser to localhost:9090 and see if anything comes up.

To connect the dummy device,

   ola_patch -d 1 -p 0 -u 0

Universe 0 should then be listed in both the web interface and in:

   ola_uni_info

If those things work, the only remaining thing to test is actual
hardware control, but we would be in pretty good shape.

Thanks again.

--
John Foerch

Re: [PATCH] gnu: Add ola.

[rennes]

John,

> Thank you so much for doing this.  If 'make check' succeeds, those are
> the main tests, but to check installation, I would look for the
> following programs being installed:
> 
>     ola                   ola_e131        ola_plugin_state   
> ola_rdm_set
>     ola_set_priority      ola_trigger     ola_uni_name       ola_artnet
>     ola_dmxconsole        ola_patch       ola_rdm_discover   
> ola_recorder
>     ola_streaming_client  ola_uni_info    ola_uni_stats      olad
>     ola_dmxmonitor        ola_plugin_info ola_rdm_get        
> ola_set_dmx
>     ola_timecode          ola_uni_merge   ola_usbpro         
> ola_dev_info
> 

I see only the following programs:

ola_artnet            ola_plugin_state      ola_set_priority      
ola_uni_name
olad                  ola_rdm_discover      ola_streaming_client  
ola_uni_stats
ola_dev_info          ola_rdm_get           ola_timecode          
ola_usbpro
ola_e131              ola_rdm_set           ola_trigger
ola_patch             ola_recorder          ola_uni_info
ola_plugin_info       ola_set_dmx           ola_uni_merge


> These are the programs installed by the Debian ola package, and I don't
> know what packaging options might have affected which were installed,
> but the list should be more or less the same.
> 
> To start the ola daemon and generate a config:
> 
>     olad -c ~/my-ola

when the command is run, it displays message:

$ olad -c ~/my-ola

common/io/IOUtils.cpp:39: open(/dev/dmx0): No such file or directory
plugins/opendmx/OpenDmxPlugin.cpp:80: Could not open /dev/dmx0 No such 
file or directory
common/network/IPV4Address.cpp:89: Could not convert address 677966233
common/io/IOUtils.cpp:39: open(/dev/kldmx0): No such file or directory
plugins/karate/KaratePlugin.cpp:79: Could not open /dev/kldmx0 No such 
file or directory



> This should start a web service on port 9090, so you can point a web
> browser to localhost:9090 and see if anything comes up.

the service is not responding. Any ideas?

Thanks.

Re: [PATCH] gnu: Add ola.

[John J Foerch]

rennes@openmailbox.org writes:

> John,
>
>> Thank you so much for doing this.  If 'make check' succeeds, those are
>> the main tests, but to check installation, I would look for the
>> following programs being installed:
>>
>>     ola                   ola_e131        ola_plugin_state   ola_rdm_set
>>     ola_set_priority      ola_trigger     ola_uni_name       ola_artnet
>>     ola_dmxconsole        ola_patch       ola_rdm_discover
>> ola_recorder
>>     ola_streaming_client  ola_uni_info    ola_uni_stats      olad
>>     ola_dmxmonitor        ola_plugin_info ola_rdm_get        ola_set_dmx
>>     ola_timecode          ola_uni_merge   ola_usbpro
>> ola_dev_info
>>
>
> I see only the following programs:
>
> ola_artnet            ola_plugin_state      ola_set_priority
> ola_uni_name
> olad                  ola_rdm_discover      ola_streaming_client
> ola_uni_stats
> ola_dev_info          ola_rdm_get           ola_timecode
> ola_usbpro
> ola_e131              ola_rdm_set           ola_trigger
> ola_patch             ola_recorder          ola_uni_info
> ola_plugin_info       ola_set_dmx           ola_uni_merge
>

That seems fine.  I don't know what every single one of them does, but
all of the main ones are present.

>
>> These are the programs installed by the Debian ola package, and I don't
>> know what packaging options might have affected which were installed,
>> but the list should be more or less the same.
>>
>> To start the ola daemon and generate a config:
>>
>>     olad -c ~/my-ola
>
> when the command is run, it displays message:
>
> $ olad -c ~/my-ola
>
> common/io/IOUtils.cpp:39: open(/dev/dmx0): No such file or directory
> plugins/opendmx/OpenDmxPlugin.cpp:80: Could not open /dev/dmx0 No such
> file or directory
> common/network/IPV4Address.cpp:89: Could not convert address 677966233
> common/io/IOUtils.cpp:39: open(/dev/kldmx0): No such file or directory
> plugins/karate/KaratePlugin.cpp:79: Could not open /dev/kldmx0 No such
> file or directory
>

The ones complaining about missing /dev entries are nothing to worry
about - those are plugins just looking for hardware that isn't there.
They can be disabled in files in ~/my-ola, but by default, it will
search for every kind of device.

The one that I don't know the meaning of is the IPV4Address.cpp:89
error.  I will ask about that.

>
>
>> This should start a web service on port 9090, so you can point a web
>> browser to localhost:9090 and see if anything comes up.
>
> the service is not responding. Any ideas?
>
> Thanks.

According to this page, http support is an optional build option.  I
wasn't aware of that, but it would be convenient to enable.

  https://www.openlighting.org/ola/getting-started/using-ola/#How_to_setup_an_interface

To enable it, it needs libmicrohttpd.  It looks like guix has a package
for that - nice!

Thank you,

--
John Foerch

Re: [PATCH] gnu: Add ola.

[John J Foerch]

John J Foerch <jjfoerch@earthlink.net> writes:

> rennes@openmailbox.org writes:
>
>> John,
>>
>>> Thank you so much for doing this.  If 'make check' succeeds, those are
>>> the main tests, but to check installation, I would look for the
>>> following programs being installed:
>>>
>>>     ola                   ola_e131        ola_plugin_state   ola_rdm_set
>>>     ola_set_priority      ola_trigger     ola_uni_name       ola_artnet
>>>     ola_dmxconsole        ola_patch       ola_rdm_discover
>>> ola_recorder
>>>     ola_streaming_client  ola_uni_info    ola_uni_stats      olad
>>>     ola_dmxmonitor        ola_plugin_info ola_rdm_get        ola_set_dmx
>>>     ola_timecode          ola_uni_merge   ola_usbpro
>>> ola_dev_info
>>>
>>
>> I see only the following programs:
>>
>> ola_artnet            ola_plugin_state      ola_set_priority
>> ola_uni_name
>> olad                  ola_rdm_discover      ola_streaming_client
>> ola_uni_stats
>> ola_dev_info          ola_rdm_get           ola_timecode
>> ola_usbpro
>> ola_e131              ola_rdm_set           ola_trigger
>> ola_patch             ola_recorder          ola_uni_info
>> ola_plugin_info       ola_set_dmx           ola_uni_merge
>>
>
> That seems fine.  I don't know what every single one of them does, but
> all of the main ones are present.
>
>>
>>> These are the programs installed by the Debian ola package, and I don't
>>> know what packaging options might have affected which were installed,
>>> but the list should be more or less the same.
>>>
>>> To start the ola daemon and generate a config:
>>>
>>>     olad -c ~/my-ola
>>
>> when the command is run, it displays message:
>>
>> $ olad -c ~/my-ola
>>
>> common/io/IOUtils.cpp:39: open(/dev/dmx0): No such file or directory
>> plugins/opendmx/OpenDmxPlugin.cpp:80: Could not open /dev/dmx0 No such
>> file or directory
>> common/network/IPV4Address.cpp:89: Could not convert address 677966233
>> common/io/IOUtils.cpp:39: open(/dev/kldmx0): No such file or directory
>> plugins/karate/KaratePlugin.cpp:79: Could not open /dev/kldmx0 No such
>> file or directory
>>
>
> The ones complaining about missing /dev entries are nothing to worry
> about - those are plugins just looking for hardware that isn't there.
> They can be disabled in files in ~/my-ola, but by default, it will
> search for every kind of device.
>
> The one that I don't know the meaning of is the IPV4Address.cpp:89
> error.  I will ask about that.
>
>>
>>
>>> This should start a web service on port 9090, so you can point a web
>>> browser to localhost:9090 and see if anything comes up.
>>
>> the service is not responding. Any ideas?
>>
>> Thanks.
>
> According to this page, http support is an optional build option.  I
> wasn't aware of that, but it would be convenient to enable.
>
>   https://www.openlighting.org/ola/getting-started/using-ola/#How_to_setup_an_interface
>
> To enable it, it needs libmicrohttpd.  It looks like guix has a package
> for that - nice!
>
> Thank you,
>
> --
> John Foerch

I found this to solve the memory issue, so I can build the package now:
https://github.com/OpenLightingProject/ola/issues/1103

Thank you for your help.  I am now working on some other issues with the
package and hope to post a patch soon.

--
John Foerch

Re: [PATCH] gnu: Add ola.

[John J Foerch]

Hi all,

I have made some progress with the ola package, but have run into
difficulty related to python used in its test phase.  Relevant code and
logs can be found here:

  The package definition: http://retroj.net/scratch/ola-guix/ola.scm

  The build log: http://retroj.net/scratch/ola-guix/ola-guix-build.log

  OLA's config.log: http://retroj.net/scratch/ola-guix/config.log

  Log of the test suite errors:
  http://retroj.net/scratch/ola-guix/test-suite.log

The ./configure argument --enable-rdm-tests turns on some tests that use
python.  These tests require the python-protobuf package.  Config.log
shows that protobuf was found, by whatever means autoconf uses to find
it, but the tests fail with this:

  File "/tmp/guix-build-ola-0.10.2.drv-0/ola-0.10.2/python/ola/PidStore.py",
     line 27, in <module> from google.protobuf import text_format
  ImportError: No module named 'google'

  ...

  File "/tmp/guix-build-ola-0.10.2.drv-0/ola-0.10.2/python/ola/rpc/SimpleRpcController.py",
    line 18, in <module> from google.protobuf import service
  ImportError: No module named 'google'

(For the complete messages, see links above.)

My best guess is that when the rdm tests run, PYTHONPATH does not
include whatever directory the google.protobuf module is in.  Anybody
know what's going on here?

Thank you,

--
John Foerch

[PATCH] gnu: Add ola

[John J Foerch]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hello,

Here is a package definition for ola (Open Lighting Architecture).  I
was having trouble getting ola's python bindings to build, as detailed
in an earlier message, so this patch does not include them.  I intend to
add them when I figure out how, but since they're not essential to the
function of the library, I think they need not block adding the basic
package.  Ola also provides bindings for java, but they depend on Apache
maven, which we don't seem to have a package for yet, so here again, I
think that this can be added later.

Please let me know of anything that should be changed.

Thank you,

--
John Foerch


[-- Attachment #2: gnu: Add ola --]
[-- Type: text/x-diff, Size: 3834 bytes --]

From f600e8a43997efecb9587a9c39579a7d6f3291f4 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoerch@earthlink.net>
Date: Wed, 3 Aug 2016 21:36:52 -0500
Subject: [PATCH] gnu: Add ola.

* gnu/packages/ola.scm (ola): New variable.
---
 gnu/packages/ola.scm | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)
 create mode 100644 gnu/packages/ola.scm

diff --git a/gnu/packages/ola.scm b/gnu/packages/ola.scm
new file mode 100644
index 0000000..f47c029
--- /dev/null
+++ b/gnu/packages/ola.scm
@@ -0,0 +1,77 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages ola)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages gnunet)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages libftdi)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf))
+
+(define-public ola
+  (package
+    (name "ola")
+    (version "0.10.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/OpenLightingProject/ola/releases/download/"
+                    version "/ola-" version ".tar.gz"))
+              (sha256
+               (base32
+                "09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("bison" ,bison)
+       ("cppunit" ,cppunit)
+       ("flex" ,flex)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libftdi" ,libftdi)
+       ("libmicrohttpd" ,libmicrohttpd)
+       ("libusb" ,libusb)
+       ("libuuid" ,util-linux)
+       ("zlib" ,zlib)))
+    (propagated-inputs
+     `(("protobuf" ,protobuf)))
+    (arguments
+     `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
+       ;; build to fail on low memory systems.  We disable that with the
+       ;; following configure flags.
+       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
+       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases %standard-phases))
+    (synopsis "Framework for controlling entertainment lighting equipment")
+    (description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+    (home-page "https://www.openlighting.org/ola")
+    (license license:lgpl2.1+)))
-- 
2.9.0

Re: [PATCH] gnu: Add ola

[Alex Vong]

Hi,

John J Foerch <jjfoerch@earthlink.net> writes:

> Hello,
>
> Here is a package definition for ola (Open Lighting Architecture).  I
> was having trouble getting ola's python bindings to build, as detailed
> in an earlier message, so this patch does not include them.  I intend to
> add them when I figure out how, but since they're not essential to the
> function of the library, I think they need not block adding the basic
> package.  Ola also provides bindings for java, but they depend on Apache
> maven, which we don't seem to have a package for yet, so here again, I
> think that this can be added later.
>
> Please let me know of anything that should be changed.
>
> Thank you,
>
> --
> John Foerch
>
>
> From f600e8a43997efecb9587a9c39579a7d6f3291f4 Mon Sep 17 00:00:00 2001
> From: "John J. Foerch" <jjfoerch@earthlink.net>
> Date: Wed, 3 Aug 2016 21:36:52 -0500
> Subject: [PATCH] gnu: Add ola.
>
> * gnu/packages/ola.scm (ola): New variable.
> ---
>  gnu/packages/ola.scm | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 gnu/packages/ola.scm
>
> diff --git a/gnu/packages/ola.scm b/gnu/packages/ola.scm
> new file mode 100644
> index 0000000..f47c029
> --- /dev/null
> +++ b/gnu/packages/ola.scm
> @@ -0,0 +1,77 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages ola)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix download)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages bison)
> +  #:use-module (gnu packages check)
> +  #:use-module (gnu packages compression)
> +  #:use-module (gnu packages gnunet)
> +  #:use-module (gnu packages flex)
> +  #:use-module (gnu packages libftdi)
> +  #:use-module (gnu packages libusb)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages protobuf))
> +
> +(define-public ola
> +  (package
> +    (name "ola")
> +    (version "0.10.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/OpenLightingProject/ola/releases/download/"
> +                    version "/ola-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("cppunit" ,cppunit)
> +       ("flex" ,flex)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libftdi" ,libftdi)
> +       ("libmicrohttpd" ,libmicrohttpd)
> +       ("libusb" ,libusb)
> +       ("libuuid" ,util-linux)
> +       ("zlib" ,zlib)))
> +    (propagated-inputs
> +     `(("protobuf" ,protobuf)))
> +    (arguments
> +     `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
> +       ;; build to fail on low memory systems.  We disable that with the
> +       ;; following configure flags.
> +       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       #:phases %standard-phases))
> +    (synopsis "Framework for controlling entertainment lighting equipment")
> +    (description "The Open Lighting Architecture is a framework for lighting
> +control information.  It supports a range of protocols and over a dozen USB
> +devices.  It can run as a standalone service, which is useful for converting
> +signals between protocols, or alternatively using the OLA API, it can be used
> +as the backend for lighting control software.  OLA runs on many different
> +platforms including ARM, which makes it a perfect fit for low cost Ethernet to
> +DMX gateways.")
> +    (home-page "https://www.openlighting.org/ola")
> +    (license license:lgpl2.1+)))

The patch builds on my machine and lgtm. I make some minor changes (in
diff format):

1. Add ola.scm to gnu/local.mk, so that the build system knows the
   presence of gnu/package/ola.scm. The commit message should say this
   as well.

2. Move protobuf from propagated-inputs to inputs. I don't know if this
   is right. But usually library depedencies don't need to be propagated
   (?), only command line tools needed at run-time need to be
   propagated, right?

3. Remove make-flags and phases. %standard-phases is the implicit
   phases, so there is no need to specify it. I think PREFIX is already
   handled by gnu-build-system. So it is not needed.


2 files changed, 4 insertions(+), 6 deletions(-)
gnu/local.mk         | 1 +
gnu/packages/ola.scm | 9 +++------

modified   gnu/local.mk
@@ -261,6 +261,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/nvi.scm				\
   %D%/packages/ocaml.scm			\
   %D%/packages/ocr.scm				\
+  %D%/packages/ola.scm				\
   %D%/packages/onc-rpc.scm			\
   %D%/packages/openbox.scm			\
   %D%/packages/openldap.scm			\
modified   gnu/packages/ola.scm
@@ -55,16 +55,13 @@
        ("libmicrohttpd" ,libmicrohttpd)
        ("libusb" ,libusb)
        ("libuuid" ,util-linux)
-       ("zlib" ,zlib)))
-    (propagated-inputs
-     `(("protobuf" ,protobuf)))
+       ("zlib" ,zlib)
+       ("protobuf" ,protobuf)))
     (arguments
      `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
        ;; build to fail on low memory systems.  We disable that with the
        ;; following configure flags.
-       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
-       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
-       #:phases %standard-phases))
+       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
     (synopsis "Framework for controlling entertainment lighting equipment")
     (description "The Open Lighting Architecture is a framework for lighting
 control information.  It supports a range of protocols and over a dozen USB


Thanks for the patch. How do the others think?

Cheers,
Alex

Re: [PATCH] gnu: Add ola

[Marius Bakke]

> 2 files changed, 4 insertions(+), 6 deletions(-)
> gnu/local.mk         | 1 +
> gnu/packages/ola.scm | 9 +++------

Perhaps this could be added to something like automation.scm?
Or iot.scm?

> +    (synopsis "Framework for controlling entertainment lighting equipment")
> +    (description "The Open Lighting Architecture is a framework for lighting
> +control information.  It supports a range of protocols and over a dozen USB
> +devices.  It can run as a standalone service, which is useful for converting
> +signals between protocols, or alternatively using the OLA API, it can be used
> +as the backend for lighting control software.  OLA runs on many different
> +platforms including ARM, which makes it a perfect fit for low cost Ethernet to
> +DMX gateways.")

Marius

Re: [PATCH] gnu: Add ola

[John J Foerch]

Alex Vong <alexvong1995@gmail.com> writes:

> Hi,
>
> The patch builds on my machine and lgtm. I make some minor changes (in
> diff format):
>
> 1. Add ola.scm to gnu/local.mk, so that the build system knows the
>    presence of gnu/package/ola.scm. The commit message should say this
>    as well.
>
> 2. Move protobuf from propagated-inputs to inputs. I don't know if this
>    is right. But usually library depedencies don't need to be propagated
>    (?), only command line tools needed at run-time need to be
>    propagated, right?
>
> 3. Remove make-flags and phases. %standard-phases is the implicit
>    phases, so there is no need to specify it. I think PREFIX is already
>    handled by gnu-build-system. So it is not needed.
>
>
> 2 files changed, 4 insertions(+), 6 deletions(-)
> gnu/local.mk         | 1 +
> gnu/packages/ola.scm | 9 +++------
>
> modified   gnu/local.mk
> @@ -261,6 +261,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/nvi.scm				\
>    %D%/packages/ocaml.scm			\
>    %D%/packages/ocr.scm				\
> +  %D%/packages/ola.scm				\
>    %D%/packages/onc-rpc.scm			\
>    %D%/packages/openbox.scm			\
>    %D%/packages/openldap.scm			\
> modified   gnu/packages/ola.scm
> @@ -55,16 +55,13 @@
>         ("libmicrohttpd" ,libmicrohttpd)
>         ("libusb" ,libusb)
>         ("libuuid" ,util-linux)
> -       ("zlib" ,zlib)))
> -    (propagated-inputs
> -     `(("protobuf" ,protobuf)))
> +       ("zlib" ,zlib)
> +       ("protobuf" ,protobuf)))
>      (arguments
>       `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
>         ;; build to fail on low memory systems.  We disable that with the
>         ;; following configure flags.
> -       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
> -       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> -       #:phases %standard-phases))
> +       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
>      (synopsis "Framework for controlling entertainment lighting equipment")
>      (description "The Open Lighting Architecture is a framework for lighting
>  control information.  It supports a range of protocols and over a dozen USB
>
>
> Thanks for the patch. How do the others think?
>
> Cheers,
> Alex


Hello,

Thank you for taking a look and for catching those details.  Protobuf as
a propagated input is correct however - it is needed for 'pkg-config
--libs libola'.

--
John Foerch

Re: [PATCH] gnu: Add ola

[Ludovic Courtès]

Hi,

Marius Bakke <mbakke@fastmail.com> skribis:

>> 2 files changed, 4 insertions(+), 6 deletions(-)
>> gnu/local.mk         | 1 +
>> gnu/packages/ola.scm | 9 +++------
>
> Perhaps this could be added to something like automation.scm?

Makes sense to me, unless there are many other OLA-related packages.

John: could you send an updated patch incorporating suggestions from
Alex and Marius?  The rest LGTM.

Thanks!

Ludo’.

Re: [PATCH] gnu: Add ola

[John J Foerch]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>> gnu/local.mk         | 1 +
>>> gnu/packages/ola.scm | 9 +++------
>>
>> Perhaps this could be added to something like automation.scm?
>
> Makes sense to me, unless there are many other OLA-related packages.
>
> John: could you send an updated patch incorporating suggestions from
> Alex and Marius?  The rest LGTM.
>
> Thanks!
>
> Ludo’.

How about lighting.scm?  There are a few other lighting programs that
could potentially be packaged.

--
John Foerch

Re: [PATCH] gnu: Add ola

[Ludovic Courtès]

John J Foerch <jjfoerch@earthlink.net> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Hi,
>>
>> Marius Bakke <mbakke@fastmail.com> skribis:
>>
>>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>>> gnu/local.mk         | 1 +
>>>> gnu/packages/ola.scm | 9 +++------
>>>
>>> Perhaps this could be added to something like automation.scm?
>>
>> Makes sense to me, unless there are many other OLA-related packages.
>>
>> John: could you send an updated patch incorporating suggestions from
>> Alex and Marius?  The rest LGTM.
>>
>> Thanks!
>>
>> Ludo’.
>
> How about lighting.scm?  There are a few other lighting programs that
> could potentially be packaged.

Sure, fine with me!

Ludo’.

Re: [PATCH] gnu: Add ola

[John J Foerch]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> John J Foerch <jjfoerch@earthlink.net> skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Hi,
>>>
>>> Marius Bakke <mbakke@fastmail.com> skribis:
>>>
>>>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>>>> gnu/local.mk         | 1 +
>>>>> gnu/packages/ola.scm | 9 +++------
>>>>
>>>> Perhaps this could be added to something like automation.scm?
>>>
>>> Makes sense to me, unless there are many other OLA-related packages.
>>>
>>> John: could you send an updated patch incorporating suggestions from
>>> Alex and Marius?  The rest LGTM.
>>>
>>> Thanks!
>>>
>>> Ludo’.
>>
>> How about lighting.scm?  There are a few other lighting programs that
>> could potentially be packaged.
>
> Sure, fine with me!
>
> Ludo’.

Here it is!


[-- Attachment #2: gnu: Add ola. --]
[-- Type: text/x-diff, Size: 4204 bytes --]

From d4738938d325dcf0452346f48f0bf02c020bd6d2 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoerch@earthlink.net>
Date: Wed, 3 Aug 2016 21:36:52 -0500
Subject: [PATCH] gnu: Add ola.

* gnu/packages/ola.scm (ola): New variable.
---
 gnu/local.mk              |  1 +
 gnu/packages/lighting.scm | 75 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)
 create mode 100644 gnu/packages/lighting.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index efb00b9..9c27e11 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -213,6 +213,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/libusb.scm			\
   %D%/packages/libunwind.scm			\
   %D%/packages/libupnp.scm			\
+  %D%/packages/lighting.scm                     \
   %D%/packages/links.scm			\
   %D%/packages/linux.scm			\
   %D%/packages/lirc.scm				\
diff --git a/gnu/packages/lighting.scm b/gnu/packages/lighting.scm
new file mode 100644
index 0000000..5101fba
--- /dev/null
+++ b/gnu/packages/lighting.scm
@@ -0,0 +1,75 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lighting)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages gnunet)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages libftdi)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf))
+
+(define-public ola
+  (package
+    (name "ola")
+    (version "0.10.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/OpenLightingProject/ola/releases/download/"
+                    version "/ola-" version ".tar.gz"))
+              (sha256
+               (base32
+                "09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("bison" ,bison)
+       ("cppunit" ,cppunit)
+       ("flex" ,flex)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libftdi" ,libftdi)
+       ("libmicrohttpd" ,libmicrohttpd)
+       ("libusb" ,libusb)
+       ("libuuid" ,util-linux)
+       ("zlib" ,zlib)))
+    (propagated-inputs
+     `(("protobuf" ,protobuf))) ;; for pkg-config --libs libola
+    (arguments
+     `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
+       ;; build to fail on low memory systems.  We disable that with the
+       ;; following configure flags.
+       #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
+    (synopsis "Framework for controlling entertainment lighting equipment")
+    (description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+    (home-page "https://www.openlighting.org/ola")
+    (license license:lgpl2.1+)))
-- 
2.9.3

Re: [PATCH] gnu: Add ola

[Ludovic Courtès]

John J Foerch <jjfoerch@earthlink.net> skribis:

> From d4738938d325dcf0452346f48f0bf02c020bd6d2 Mon Sep 17 00:00:00 2001
> From: "John J. Foerch" <jjfoerch@earthlink.net>
> Date: Wed, 3 Aug 2016 21:36:52 -0500
> Subject: [PATCH] gnu: Add ola.
>
> * gnu/packages/ola.scm (ola): New variable.

Applied, thanks!

Ludo’.