From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/9] services: syslog: Use syslog-configuration.
Date: Fri, 02 Sep 2016 14:31:25 +0200 [thread overview]
Message-ID: <87r392mqjm.fsf@gnu.org> (raw)
In-Reply-To: <20160901155711.7388-4-david@craven.ch> (David Craven's message of "Thu, 1 Sep 2016 17:57:06 +0200")
David Craven <david@craven.ch> skribis:
> * gnu/services/base.scm (<syslog-configuration>): New variable.
> (syslog-service-type): Use <syslog-configuration>.
> (syslog-service): Use <syslog-configuration>.
Please mention the gnu/tests/base.scm changes here.
> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -73,15 +73,15 @@
>
> %nscd-default-caches
> %nscd-default-configuration
> -
> nscd-configuration
> nscd-configuration?
> -
> nscd-cache
> nscd-cache?
> -
Please keep the spacing.
> +(define-record-type* <syslog-configuration>
> + syslog-configuration make-syslog-configuration
> + syslog-configuration?
> + (syslogd syslog-configuration-syslogd
> + (default #~(string-append #$inetutils "/libexec/syslogd")))
> + (config-file syslog-configuration-config-file
> + (default %default-syslog.conf)))
Good idea!
> -(define* (syslog-service #:key (config-file %default-syslog.conf))
> +(define* (syslog-service #:optional (config (syslog-configuration)))
> "Return a service that runs @command{syslogd}. If configuration file
> name @var{config-file} is not specified, use some reasonable default
> settings.
>
> @xref{syslogd invocation,,, inetutils, GNU Inetutils}, for more
> information on the configuration file syntax."
> - (service syslog-service-type config-file))
> + (service syslog-service-type config))
Could you update the docstring and guix.texi, and add an @deftp for
‘syslog-configuration’ in guix.texi?
TIA!
Ludo’.
next prev parent reply other threads:[~2016-09-02 12:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 15:57 [PATCH 1/9] system: vm: Remove -net user flag David Craven
2016-09-01 15:57 ` [PATCH 2/9] activation: Allow /var/lib to be a home directory David Craven
2016-09-02 11:54 ` 宋文武
2016-09-02 15:31 ` Vincent Legoll
2016-09-02 17:13 ` ng0
2016-09-02 17:19 ` David Craven
2016-09-03 13:24 ` Ludovic Courtès
2016-09-01 15:57 ` [PATCH 3/9] services: Export initrc David Craven
2016-09-03 13:34 ` Ludovic Courtès
2016-09-03 13:34 ` David Craven
2016-09-03 17:33 ` David Craven
2016-09-05 8:40 ` Ludovic Courtès
2016-09-01 15:57 ` [PATCH 4/9] services: syslog: Use syslog-configuration David Craven
2016-09-02 12:31 ` Ludovic Courtès [this message]
2016-09-01 15:57 ` [PATCH 5/9] gnu: Add prefix to license imports in (gnu packages display-managers) David Craven
2016-09-02 12:27 ` Ludovic Courtès
2016-09-01 15:57 ` [PATCH 6/9] gnu: Add greenisland David Craven
2016-09-02 13:20 ` Ludovic Courtès
2016-09-03 17:03 ` David Craven
2016-09-05 8:43 ` Ludovic Courtès
2016-09-05 11:44 ` David Craven
2016-09-07 6:50 ` Mark H Weaver
2016-09-01 15:57 ` [PATCH 7/9] gnu: Add sddm David Craven
2016-09-02 12:26 ` Ludovic Courtès
2016-09-01 15:57 ` [PATCH 8/9] services: Add sddm service David Craven
2016-09-02 12:26 ` 宋文武
2016-09-03 13:32 ` Ludovic Courtès
2016-09-03 13:34 ` David Craven
2016-09-03 13:36 ` David Craven
2016-09-05 8:39 ` Ludovic Courtès
2016-09-05 8:38 ` Ludovic Courtès
2016-09-01 15:57 ` [PATCH 9/9] gnu: Add weston David Craven
2016-09-01 16:00 ` David Craven
2016-09-03 13:29 ` Ludovic Courtès
2016-09-04 14:01 ` David Craven
2016-09-05 21:15 ` Ludovic Courtès
2016-09-06 16:03 ` David Craven
2016-09-07 6:45 ` Mark H Weaver
2016-09-07 7:08 ` David Craven
2016-09-02 11:19 ` [PATCH 1/9] system: vm: Remove -net user flag ng0
2016-09-02 12:24 ` David Craven
2016-09-02 12:58 ` ng0
2016-09-02 13:00 ` David Craven
2016-09-03 13:39 ` Ludovic Courtès
2016-09-03 13:44 ` David Craven
2016-09-05 8:41 ` Ludovic Courtès
2016-09-02 15:37 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r392mqjm.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.