From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH]: opensmtpd, opensmtpd-extras, libasr. Date: Thu, 08 Sep 2016 18:36:01 +0100 Message-ID: <87r38us39a.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <87lgz2tzfq.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3FM-0002bN-JJ for guix-devel@gnu.org; Thu, 08 Sep 2016 13:36:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3FI-0006kr-TN for guix-devel@gnu.org; Thu, 08 Sep 2016 13:36:19 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3FG-0006io-Jh for guix-devel@gnu.org; Thu, 08 Sep 2016 13:36:16 -0400 In-Reply-To: <87lgz2tzfq.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 , guix-devel@gnu.org ng0 writes: > From 30c8260a039d4c8d7cddbfd92341afa65577d680 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Tue, 6 Sep 2016 17:10:18 +0000 > Subject: [PATCH 1/3] gnu: Add libasr. > > * gnu/packages/web.scm (libasr): New variable. Nice! > --- > gnu/packages/web.scm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >From reading the description below, should this not go in dns.scm? > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 70bfd9e..59ae049 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -61,6 +61,7 @@ > #:use-module (gnu packages gnome) > #:use-module (gnu packages gperf) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages groff) > #:use-module (gnu packages icu4c) > #:use-module (gnu packages image) > #:use-module (gnu packages lua) > @@ -3609,3 +3610,35 @@ tools they trust (e.g. wget).") > rendering engine entirely written from scratch. It is small and capable of > handling many of the web standards in use today.") > (license l:gpl2+))) > + > +(define-public libasr > + (package > + (name "libasr") > + (version "201602131606") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://www.opensmtpd.org/archives/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "18kdmbjsxrfai16d66qslp48b1zf7gr8him2jj5dcqgbsl44ls75")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("pkg-config" ,pkg-config) > + ("groff" ,groff))) > + (home-page "https://www.opensmtpd.org") > + (synopsis "Asynchronous resolver library by the OpenBSD project") > + (description > + "libasr is a free, simple and portable asynchronous resolver library. > +It allows to run dns queries and perform hostname resolutions in a fully ^^^ Please capitalize. > +asynchronous fashion. The implementation is thread-less, fork-less, and > +does not make use of signals or other 'tricks' that might get in the > +developer's way.") The second sentence may be left off, IMO. > + (license (list l:isc > + l:bsd-2 ; last part of getrrsetbyname_async.c > + l:bsd-3 > + (l:non-copyleft "file://COPYING") ; includes.h This should probably be "file://LICENSE". > + l:openssl)))) Why is OpenSSL listed? Grepping for 'openssl' returns no results. The rest of this patch LGTM. I won't comment on the other two as I don't know enough about how paths and user accounts is usually handled. Cheers, Marius