From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add python-cachecontrol. Date: Sun, 11 Sep 2016 02:11:08 +0100 Message-ID: <87r38rckb7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <87mvjgqcgy.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <40a18799-2091-6ed2-bd96-f5d37c20dcfb@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bitIs-0007Rw-Un for guix-devel@gnu.org; Sat, 10 Sep 2016 21:11:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bitIo-0008OW-6S for guix-devel@gnu.org; Sat, 10 Sep 2016 21:11:26 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bitIl-0008NI-O1 for guix-devel@gnu.org; Sat, 10 Sep 2016 21:11:22 -0400 In-Reply-To: <40a18799-2091-6ed2-bd96-f5d37c20dcfb@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft , guix-devel@gnu.org Ben Woodcroft writes: > Hi Marius, thanks for the patch. > > I added a 'python2-variant' line and pushed as 'b30565b'. *facepalm* thanks. Here I was wondering why my next patches didn't build for python2. You may want to do the same for "python-freezegun" above. Btw, it seems you missed a couple of parenthesis in the commit: - (properties `((python2-variant . ,(delay python2-cachecontrol))) + (properties `((python2-variant . ,(delay python2-cachecontrol)))))) > The thing is, the list has already seen this package before, in this > thread where I tried packaging scikit-bio (I suspect you are trying to > do the same): > https://lists.gnu.org/archive/html/guix-devel/2016-04/msg01012.html I am indeed sending these to prepare for scikit-bio. Natsort coming up. There have been a few dependency updates as well, since that thread. I'll take a look at your branch to see if it contains anything I might have missed. The remaining dependencies are pretty much ready to go. Cheers! Marius