From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 12/17] gnu: make-linux-libre: Add extra-version parameter.
Date: Sun, 11 Sep 2016 23:32:16 +0200
Message-ID: <87r38qf7hb.fsf@gnu.org>
References: <20160909013641.GA9202@jasmine>
	<20160909123426.18499-1-david@craven.ch>
	<20160909123426.18499-12-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjCMS-0006xP-2d
	for guix-devel@gnu.org; Sun, 11 Sep 2016 17:32:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjCMO-0000IH-GG
	for guix-devel@gnu.org; Sun, 11 Sep 2016 17:32:23 -0400
In-Reply-To: <20160909123426.18499-12-david@craven.ch> (David Craven's message
	of "Fri, 9 Sep 2016 14:34:21 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/linux.scm (make-linux-libre): Add extra-version option.
> ---
>  gnu/packages/linux.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 6771bd2..f2e6887 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -274,12 +274,15 @@ for SYSTEM and optionally VARIANT, or #f if there i=
s no such configuration."
>=20=20
>  (define* (make-linux-libre version source
>                             #:key
> +                           (extra-version #f)
>                             (configuration-file #f)
>                             (defconfig "defconfig")
>                             (additional-configuration
>                              %default-additional-kernel-configuration))
>    (package
> -    (name "linux-libre")
> +    (name (if extra-version
> +              (string-append "linux-libre-" extra-version)
> +              "linux-libre"))

s/extra-version/variant/, since it=E2=80=99s not something that goes to the
=E2=80=98version=E2=80=99 field.  WDYT?

Otherwise OK.

Ludo=E2=80=99.