From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [Patch 1/10] Add pjproject. Date: Mon, 26 Sep 2016 01:41:02 -0500 Message-ID: <87r387tb7l.fsf@openmailbox.org> References: <87mvjc1quq.fsf@openmailbox.org> <87inu01qsj.fsf@openmailbox.org> <87shswmj48.fsf@elephly.net> <87oa3j870k.fsf@openmailbox.org> <87bmzg8xe1.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boPbR-0003RN-NB for guix-devel@gnu.org; Mon, 26 Sep 2016 02:41:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boPbN-0007RY-GP for guix-devel@gnu.org; Mon, 26 Sep 2016 02:41:24 -0400 Received: from smtp11.openmailbox.org ([62.4.1.45]:43301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boPbN-0007Ql-6i for guix-devel@gnu.org; Mon, 26 Sep 2016 02:41:21 -0400 In-Reply-To: <87bmzg8xe1.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 22 Sep 2016 04:46:14 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ricardo, Sorry for the delay! Ricardo Wurmus writes: >> My idea here is the following: The source tree downloaded here contains >> the complete source for libring, which includes the patches to >> pjproject. In this snippet I try to get rid of all the other libring >> files that are not needed and only keep the patches to pjproject. Then >> I try to make the directory tree that contains these patches as shallow >> as possible. I remember I had some problems with copying them to "." >> but trying again now it works. I attached an updated patch that does >> this. > > Is there no release that includes these patches? Why do we have to > apply them ourselves? In Guix we try to avoid patching upstream sources > with functional patches (as opposed to patches that fix problems with > building the software on Guix), as this is really upstream=E2=80=99s work. There is no release that I know of that contains these patches. The Ring project ships a Makefile in the 'contrib' directory of the 'libring' source tree that downloads the upstream Pjproject source and applies these very same patches to it. It then continues to build a bundled version of pjproject + patches. > Is this really pjproject version 2.4 when we apply a massive patch set > like that? It is not. It is a fork of pjproject that introduces several functional changes, the most notable one being the use of GnuTLS instead of OpenSSL. I suspect the Ring project's motivation for doing this are at least in part legal issues as the OpenSSL license seems to be incompatible with the GPL according to "http://www.gnu.org/licenses/license-list.html". I don't know if there are technical benefits of using one over the other. I tried to denote the fact that this is a fork of pjproject by naming the variable 'pjproject-sfl' instead of just 'pjproject'. I could go further and make it local to the definition of libring or change the name of the package? Thank you! Best, Lukas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6ML+AAoJEFP7dyh+2DCRZy8QAJibF+NGJcx20wIkR5pa2xg7 UCGa468tEpJhiHvHBl10MR0c4CUydfLwh3vZvm+7plco0DsiGpqRLCJ3b3Cmmmi0 cZi2ci8ct9lUOPXMG5aq1rS4D5XySNm/0kXjb64woWEjI3tlGEKVbew7EZeicyH+ k8EqWoD4w05+U7G/0hgMBUpCSDQo7XydqOUpVsvvJXr0Hhad2czEtkOJuEq//G0R 3m3bO+Oy6K8MoaVNeOZ3QzIGxfbn8BGYC3/TwartuZOSysPy1xt3l68wJB9qRShM QZj1Rc6QO9B42NEDEhK/Jifs1ZbE3y1ITfOjffs6Cq/m+YYpQ5SEggjn8F+4C/R4 fX7ReJXIEEgzpYNfeJAIrHGTB0qT5B9QwJSo0uC+nM8tRfCLJVS7wRR/lq3LaMEo 2IX0cUZotI9nZsz40moyzTaOUjwd6R8IGfIPMYmJqUfVIsRmzqqC/rZWFHfqNgII EPQugxnl+fhCx3Ztb4UPG8LYU3vThLXxSzSFdF4Ndy5ROTsmB19Hp3f/PHDvua96 8k/KDmohqyhEfnR5F8Q5EytBNIIRgNxFcJCGoYgJz+g3Yj4IRuo6JFi4eUoAwLG3 8WnDTTdNM1f2KCAgcdYsAh80NOsR+DWkoQmJIITSzrk9egPJ+zFD6ekjKksoLXfu /JZ63ubtqWJql5+do5wg =DN+r -----END PGP SIGNATURE----- --=-=-=--