all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: Superseded packages
Date: Wed, 28 Sep 2016 10:44:26 +0200	[thread overview]
Message-ID: <87r3844dn9.fsf@gnu.org> (raw)
In-Reply-To: <20160925164208.GA7317@jasmine> (Leo Famulari's message of "Sun, 25 Sep 2016 12:42:08 -0400")

Leo Famulari <leo@famulari.name> skribis:

> On Sat, Sep 24, 2016 at 11:14:41AM +0900, Ludovic Courtès wrote:
>> Leo Famulari <leo@famulari.name> skribis:
>> > +(define-public attic
>> > +  (package (inherit borg)
>> > +    (name "attic")
>> > +    (properties `((superseded . ,borg)))))
>> 
>> I was thinking that we could keep the ‘attic’ recipe as-is, only with
>> this extra ‘properties’ field.
>> 
>> That way, “guix package -u” and “guix package -i attic” would install
>> Borg, but people who insist could still run:
>> 
>>   guix package -e '(@ (gnu packages backup) attic)'
>> 
>> Thoughts?
>
> That's a much better idea than what I had proposed.
>
> I found that I had to move the attic package definition below borg's, or
> else the borg variable was unbound when building (gnu packages backup):

[...]

> So the attached patch moves attic after borg and supersedes it. Is it
> expected that we have to shuffle the package definition around like
> this?

Yes, because ‘properties’ are evaluated eagerly.

We could change the ‘superseded’ property to always be a promise, as
Efraim suggests; we’ll see later if that’s really necessary.

The patch LGTM.

Thank you!

Ludo’.

  parent reply	other threads:[~2016-09-28  8:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04  2:12 Removing the attic package Leo Famulari
2016-09-04 13:10 ` ng0
2016-09-04 18:44   ` Leo Famulari
2016-09-05  8:20     ` Ludovic Courtès
2016-09-05  8:34       ` Ricardo Wurmus
2016-09-05  9:29       ` Efraim Flashner
2016-09-05 10:05         ` ng0
2016-09-05 10:20           ` ng0
2016-09-06 21:36       ` Superseded packages Ludovic Courtès
2016-09-10 17:25         ` Leo Famulari
2016-09-11 13:46           ` Ludovic Courtès
2016-09-11 15:19             ` Leo Famulari
2016-09-11 20:39               ` Ludovic Courtès
2016-09-20 21:18                 ` Leo Famulari
2016-09-24  2:14                   ` Ludovic Courtès
2016-09-25 16:42                     ` Leo Famulari
2016-09-26  9:44                       ` Efraim Flashner
2016-09-27 21:39                         ` Leo Famulari
2016-09-28  8:44                       ` Ludovic Courtès [this message]
2016-09-28 17:58                         ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3844dn9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.