From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add qscintilla.
Date: Mon, 03 Oct 2016 18:17:18 +0200
Message-ID: <87r37x8l0x.fsf@gnu.org>
References: <87k2efd6gy.fsf@openmailbox.org>
	<20160913193906.GC31892@macbook42.flashner.co.il>
	<874m5jcz8w.fsf@openmailbox.org> <20160918083656.GA4235@solar>
	<87wpi9geag.fsf@openmailbox.org> <20160918205634.GA11923@jasmine>
	<20160918210202.GA853@macbook42.flashner.co.il>
	<8760psjadm.fsf@openmailbox.org> <874m5cm36o.fsf@elephly.net>
	<871t0gj68z.fsf@openmailbox.org> <20160919213214.GA10174@jasmine>
	<87wpi7imww.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1br5vk-0006dA-8R
	for guix-devel@gnu.org; Mon, 03 Oct 2016 12:17:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1br5ve-0006GU-8t
	for guix-devel@gnu.org; Mon, 03 Oct 2016 12:17:27 -0400
In-Reply-To: <87wpi7imww.fsf@openmailbox.org> (Kei Kebreau's message of "Mon,
	19 Sep 2016 17:45:35 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org

Kei Kebreau <kei@openmailbox.org> skribis:

> From ae862b8a51d15f165dc9b40dc46c2e209736f3a8 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Mon, 19 Sep 2016 10:11:20 -0400
> Subject: [PATCH] gnu: Add qscintilla-qt4.
>
> * gnu/packages/maths.scm (qscintilla-qt4): New variable.
> ---
>  gnu/packages/maths.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 44a24ef..829fc7a 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -77,6 +77,7 @@
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages qt)
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages tbb)
>    #:use-module (gnu packages shells)
> @@ -747,6 +748,16 @@ Work may be performed both at the interactive comman=
d-line as well as via
>  script files.")
>      (license license:gpl3+)))
>=20=20
> +;; required for Octave until its GUI is updated to Qt 5
> +(define qscintilla-qt4
> +  (package
> +    (inherit qscintilla)
> +    (name "qscintilla-qt4")
> +    (native-inputs
> +     `(("python-pyqt" ,python-pyqt-4)
> +       ("qt" ,qt-4))) ; for qmake
> +    (synopsis "Qt4 port of the Scintilla editing component")))

In general we must not have packages that inherit from packages coming
from another module.

This restriction stems from the fact that there are circular
dependencies among (gnu packages =E2=80=A6) modules.  Here, running the
top-level of (gnu packages maths) requires evaluating the top-level of
(gnu packages qt), which in turn presumably requires evaluating the
top-level of (gnu packages maths).  Boom.

The solution would be to move this package variant in the same module as
qscintilla itself.  Is it OK?

HTH,
Ludo=E2=80=99.