From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add vim-full.
Date: Tue, 18 Oct 2016 12:47:46 +0100 [thread overview]
Message-ID: <87r37d7ual.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87y41m1tm8.fsf@we.make.ritual.n0.is>
ng0 <ng0@we.make.ritual.n0.is> writes:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Hi,
>>>
>>> thanks for reviewing.
>>>
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>>
>>>>> * gnu/packages/vim.scm (vim-full): New variable.
>>>>> * gnu/packages/patches/vim-8.0.0003.patch: New file.
>>>>> * gnu/packages/patches/vim-8.0.0004.patch: New file.
>>>>> * gnu/packages/patches/vim-8.0.0005.patch: New file.
>>>>> * gnu/local.mk (dist_patch_DATA): Add patches.
>>>>> ---
>>>>> gnu/local.mk | 3 ++
>>>>> gnu/packages/patches/vim-8.0.0003.patch | 87 +++++++++++++++++++++++++++++++++
>>>>> gnu/packages/patches/vim-8.0.0004.patch | 60 +++++++++++++++++++++++
>>>>> gnu/packages/patches/vim-8.0.0005.patch | 45 +++++++++++++++++
>>>>> gnu/packages/vim.scm | 81 ++++++++++++++++++++++++++++++
>>>>> 5 files changed, 276 insertions(+)
>>>>> create mode 100644 gnu/packages/patches/vim-8.0.0003.patch
>>>>> create mode 100644 gnu/packages/patches/vim-8.0.0004.patch
>>>>> create mode 100644 gnu/packages/patches/vim-8.0.0005.patch
>>>>
>>>> [...]
>>>>
>>>>> +
>>>>> +(define-public vim-full
>>>>> + (package
>>>>> + (inherit vim)
>>>>> + (name "vim-full")
>>>>> + (version (package-version vim))
>>>>> + (source
>>>>> + (origin
>>>>> + (method url-fetch)
>>>>> + (uri (string-append "ftp://ftp.vim.org/pub/vim/unix/vim-"
>>>>> + version ".tar.bz2"))
>>>>> + (sha256
>>>>> + (base32
>>>>> + "1s34rf8089klsbdx5l0iw7vjymir0kzfrx8wb30s31wygnq29axc"))
>>>>> + ;; Patches need to be applied sequentially. 8.0 is the release of
>>>>> + ;; vim version 8.0.0002 so we start at 8.0.0003
>>>>> + (patches (search-patches "vim-8.0.0003.patch"
>>>>> + "vim-8.0.0004.patch"
>>>>> + "vim-8.0.0005.patch"))))
>>>>
>>>> Shouldn't these patches be applied on the base vim package? Then
>>>> "vim-full" can just inherit the source from there. I also think
>>>> "version" should be adjusted to match the patch level.
>>>
>>> No (for explanation see the other emails I've sent in the earlier
>>> thread).
>>> I agree on the version, I will update that.
>>
>> Upstream recommends using the Github releases [0]
>
> Where? Do you have any link for that quote so I can link it?
On the download page [0], there is a GitHub link that says "obtain
sources with a git client (recommended)". And further down that this
version includes all patches.
It goes on to describe how to clone it, but it does suggest to me that
the GitHub repo is a trusted source. What do you think?
0: http://www.vim.org/download.php
next prev parent reply other threads:[~2016-10-18 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 20:38 [PATCH] Add vim-full (this time with the patches included) ng0
2016-10-15 20:38 ` [PATCH] gnu: Add vim-full ng0
2016-10-17 16:32 ` vim-full v2 ng0
2016-10-17 16:32 ` [PATCH] gnu: Add vim-full ng0
2016-10-17 18:15 ` Marius Bakke
2016-10-17 21:07 ` ng0
2016-10-17 22:10 ` Marius Bakke
2016-10-17 22:46 ` ng0
2016-10-18 11:47 ` Marius Bakke [this message]
2016-10-17 18:37 ` Kei Kebreau
2016-10-17 21:09 ` ng0
-- strict thread matches above, loose matches on Subject: below --
2016-10-14 21:16 [PATCH]: " ng0
2016-10-14 21:16 ` [PATCH] gnu: " ng0
2016-10-15 18:21 ` Efraim Flashner
2016-10-15 21:27 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r37d7ual.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.