From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] tests: Don't check file-systems in container tests.
Date: Mon, 14 Nov 2016 15:42:47 +0100
Message-ID: <87r36e6s2g.fsf@gnu.org>
References: <20161112222028.235925fb@uwaterloo.ca> <87y40nh9ew.fsf@gnu.org>
	<878tsmtm0f.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49074)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c6ITF-0006wZ-Tv
	for guix-devel@gnu.org; Mon, 14 Nov 2016 09:42:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c6ITB-0003MV-Vr
	for guix-devel@gnu.org; Mon, 14 Nov 2016 09:42:53 -0500
In-Reply-To: <878tsmtm0f.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Mon, 14 Nov 2016 10:05:04 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Andy Patterson <ajpatter@uwaterloo.ca> skribis:
>>
>>> The containers test was hanging for me, and this patch fixed the
>>> problem.
>>
>> [...]
>>
>>> From 945ad44acf489b7f3a398d4ab739ec2b48477502 Mon Sep 17 00:00:00 2001
>>> From: Andy Patterson <ajpatter@uwaterloo.ca>
>>> Date: Sat, 12 Nov 2016 22:10:01 -0500
>>> Subject: [PATCH] tests: Don't check file-systems in container tests.
>>>
>>> * tests/containers.scm ("call-with-container, mnt namespace"): Don't
>>> check file-system in 'call-with-container' call.
>>> * tests/containers.scm
>>> ("call-with-container, mnt namespace, wrong bindmount"): Likewise.
>>> ---
>>>  tests/containers.scm | 6 ++++--
>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/containers.scm b/tests/containers.scm
>>> index ccd122a..745b56b 100644
>>> --- a/tests/containers.scm
>>> +++ b/tests/containers.scm
>>> @@ -84,7 +84,8 @@
>>>     (call-with-container (list (file-system
>>>                                  (device "none")
>>>                                  (mount-point "/testing")
>>> -                                (type "tmpfs")))
>>> +                                (type "tmpfs")
>>> +                                (check? #f)))
>>
>> Do you know exactly how/why it was hanging?  I imagine
>> =E2=80=98mount-file-system=E2=80=99 would try to invoke fsck.tmpfs, whic=
h doesn=E2=80=99t exist,
>> thus we get a REPL, which hangs forever.
>>
>> I guess the real question is why I didn=E2=80=99t experience it, hmm=E2=
=80=A6
>
> This is failing for me on master, I think the guix development snapshot
> needs to be updated to include this fix.

I believe commit 198eac2bca075d0e71e504f1e8c46fddc62171bb solves that.

I don=E2=80=99t think the regression has anything to do with it the recent
changes though.  It=E2=80=99s just that, contrary to what was intended in
package-management.scm, this container test wasn=E2=80=99t skipped, and it
happens to fail surprisingly in the build environment (for reasons that
one of us will undoubtedly elucidate so we don=E2=80=99t remain frustrated!=
).

Thanks,
Ludo=E2=80=99.