From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: leptonica: Update to 1.73. Date: Tue, 27 Dec 2016 17:20:19 +0100 Message-ID: <87r34twdh8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <87d1giwdvy.fsf@gmail.com> <87lgv5o1h8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87zijlcnbc.fsf@gmail.com> <87bmw0nowz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87fulbdbsk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLuUE-0002sh-Pd for guix-devel@gnu.org; Tue, 27 Dec 2016 11:20:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLuU9-0006fo-RX for guix-devel@gnu.org; Tue, 27 Dec 2016 11:20:26 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41036) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cLuU9-0006fi-N8 for guix-devel@gnu.org; Tue, 27 Dec 2016 11:20:21 -0500 In-Reply-To: <87fulbdbsk.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Taylan_Ulrich_Bay=C4=B1rl=C4=B1=2FKammer?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer" writes: > Marius Bakke writes: > >> "Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer" write= s: >> >>> You know what, Leptonica 1.74.0 has been released yesterday, so here's a >>> new patch. :-D >>> >>> But yes, the source snippet / patch for the .pc file isn't necessary >>> anymore for reasons not really clear to me. (The two libs still need to >>> be propagated and Tesseract has to link against them; maybe Tesseract >>> special-handles this and other dependents of Leptonica could still >>> benefit from a patched .pc file, but so far we don't have any other >>> dependents of Leptonica...) >>> >>> The config.h hack probably wasn't necessary anymore since 1.72; I had >>> introduced it with 1.71 where the issue existed and it didn't get >>> removed upon the 1.72 update. >>> >>> And all tests pass, without having to disable parallel tests either. >>> >>> The 1.74.0 tag on GitHub corresponds to a state in which ./configure >>> doesn't exist; the autobuild script needs to be run. >>> >>> So here's the new patch. >> >> Thanks for the clarification and update, pushed! >> >> I completely forgot to mention the origin and argument changes in the >> commit message as we usually do. Hopefully the next update can include >> that too ;-) > > Thanks. :-) > > FYI I have push access so in the future you can just tell me to push it. Oh, thanks for letting me know :-) > I guess I can be more strict with the commit lines. Usually I assume > that some changes to the rest of the recipe are implied in a version > update... I think it is useful to mention such changes in the commit message, so that one can clearly see in the git log which commit introduced e.g. a new phase, or new source URL, instead of having to dig through the full diffs (or blame) to find it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhilMMACgkQoqBt8qM6 VPrruwgApQ0mSnSBlaEXxM9iEXzhhftaf9JJBlVSewWp7L6brXCpU5hT47hVet1o /X8wSn4F/BIHttEcdrFWJBjMLG/9Y1qrepqg1Ha55eklGduuRHyPxKKgv9MVPtpR TThC7IhVxlpdVzzVT9vksToxrD6JOs/Qh9G6ObAKIlzJ6Z7yXDK2M5qdO3/jSqzj px5yVxiJM0FNm/EbiD0EATzNUeIEk+MlFqmses1cGwV3Rbbtu2Qvb7QhRcICYN7F 91U/luHK3/1JlR7i3YPnFugSgM19UFN2AX0TY5Ot0caIt1C9rdj27EtDUsVLG76u LZJnf/vxKDUv2ohwArERL6T7KbhAuw== =84uQ -----END PGP SIGNATURE----- --=-=-=--