From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add openvswitch.
Date: Sun, 29 Jan 2017 00:56:06 +0100 [thread overview]
Message-ID: <87r33myc15.fsf@gnu.org> (raw)
In-Reply-To: <20170127135616.15017-1-iyzsong@member.fsf.org> ("宋文武"'s message of "Fri, 27 Jan 2017 21:56:15 +0800")
Hi 宋文武!
宋文武 <iyzsong@member.fsf.org> skribis:
> * gnu/packages/networking.scm (openvswitch): New variable.
[...]
> + '(;; FIXME: many tests fail with:
> + ;; […]
> + ;; test -e $OVS_RUNDIR/ovs-vswitchd.pid
> + ;; ovs-appctl -t ovs-vswitchd exit
> + ;; hard failure
> + #:tests? #f
Can we assume that the failures are due to the lack of a proper
networking environment? Do they pass outside of the chroot?
It would be good to have a rough idea of why they fail.
> + (replace 'install
> + (lambda _
> + (zero? (system* "make"
> + "RUNDIR=/tmp"
> + "PKIDIR=/tmp"
> + "LOGDIR=/tmp"
> + "DBDIR=/tmp"
> + "install")))))))
I suppose this is to prevent “mkdir /var/log” or similar, right?
Perhaps worth mentioning in a comment.
The rest LGTM.
Thanks!
Ludo’.
next prev parent reply other threads:[~2017-01-28 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 13:56 [PATCH 1/2] gnu: Add openvswitch 宋文武
2017-01-27 13:56 ` [PATCH 2/2] services: Add openvswitch-service-type 宋文武
2017-01-29 0:02 ` Ludovic Courtès
2017-01-27 14:53 ` [PATCH 1/2] gnu: Add openvswitch John Darrington
2017-02-09 12:24 ` 宋文武
2017-01-27 18:23 ` Marius Bakke
2017-02-09 12:26 ` 宋文武
2017-01-28 23:56 ` Ludovic Courtès [this message]
2017-02-09 12:46 ` 宋文武
2017-02-10 12:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r33myc15.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.