From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csTBt-0001Xw-C8
	for guix-patches@gnu.org; Mon, 27 Mar 2017 07:52:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csTBq-0006RH-8W
	for guix-patches@gnu.org; Mon, 27 Mar 2017 07:52:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48718)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1csTBq-0006R9-55
	for guix-patches@gnu.org; Mon, 27 Mar 2017 07:52:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csTBp-0006X3-Vr
	for guix-patches@gnu.org; Mon, 27 Mar 2017 07:52:02 -0400
Subject: bug#26256: [PATCH 5/6] gnu: Add userspace-rcu.
Resent-Message-ID: <handler.26256.B26256.149061550725090@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170325203017.14931-1-mbakke@fastmail.com>
	<20170325203017.14931-5-mbakke@fastmail.com>
Date: Mon, 27 Mar 2017 13:51:32 +0200
In-Reply-To: <20170325203017.14931-5-mbakke@fastmail.com> (Marius Bakke's
	message of "Sat, 25 Mar 2017 21:30:16 +0100")
Message-ID: <87r31jj5tn.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26256@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/linux.scm (userspace-rcu): New variable.

[...]

> +    (license
> +     ;; This library is distributed under LGPL2.1+, but includes some fi=
les
> +     ;; covered by other licenses. The LICENSE file has full details.
> +     (list license:lgpl2.1+
> +           license:gpl3+                         ; most tests are gpl2+;=
 tap.sh is gpl3+
> +           license:bsd-2                         ; tests/utils/tap/tap.[=
ch]
> +           license:expat                         ; urcu/uatomic/*
> +           ;; A few files use different variants of the MIT/X11 license.
> +           (license:x11-style "file://LICENSE"
> +                              "See LICENSE in the distribution for detai=
ls.")))))

It=E2=80=99s a case where it=E2=80=99d be enough to put lgpl2.1+ and gpl3+ =
IMO, since
that=E2=80=99s what effectively applies to the resulting work.

You could still mention the other licenses in the comment though.

Otherwise LGTM, thanks!

Ludo=E2=80=99.