From: "Huang\, Ying" <huang_ying_caritas@163.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, 26308-done@debbugs.gnu.org
Subject: Re: bug#26308: [PATCH -v2] services: dict.scm: Support more dicod configuration
Date: Sat, 01 Apr 2017 19:29:05 +0800 [thread overview]
Message-ID: <87r31cl62m.fsf@163.com> (raw)
In-Reply-To: <87y3vlhxkb.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 01 Apr 2017 00:48:52 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> Hello,
>
> Huang Ying <huang.ying.caritas@gmail.com> skribis:
>
>> * gnu/services/dict.scm (<dicod-configuration>): Add handlers to configure
>> handlers (module instances).
>> (<dicod-handler>): Add new record type to describe handler (module instance).
>> (<dicod-database>): Add more fields.
>> (dicod-configuration-file): Support convert handlers and enhanced databases
>> configuration to config file.
>>
>> * doc/guix.text: Add description of newly added dicod configuration.
>
> I’ve committed with a few adjustments to the commit log and cosmetic
> changes:
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=9af7ecd9591b4eff41389291bbc586dcf09e2665
>
>> +@example
>> +(dicod-service #:config
>> + (dicod-configuration
>> + (handlers
>> + (list
>> + (dicod-handler
>> + (name "wordnet")
>> + (module "dictorg")
>> + (options
>> + '("dbdir=/gnu/store/xxxx-wordnet")))))
>
> I’ve changed this to use a real example instead of “xxx”.
>
>> (define-record-type* <dicod-database>
>> dicod-database make-dicod-database
>> dicod-database?
>> (name dicod-database-name)
>> - (module dicod-database-module)
>> + (handler dicod-database-handler)
>> + (complex dicod-database-complex (default #f))
>
> I changed that to ‘complex?’, to make it clear that it’s a Boolean.
>
> While I was at it, I wrote a simple test for the dicod service:
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=985a8599ed742053b52ac85f753c4feb54af93cb
>
> It uses the example handler that you gave in the doc, but I think this
> handler actually does nothing because WordNet does not provide data in
> the dict.org format AIUI (and its data is under “/dict” anyway.) Is
> that correct?
>
> Do you have another example in mind that could use a dict.org-formatted
> database?
There are dict.org dict for wordnet and foldoc in Debian. Some
conversion tool is needed to convert the dict database file.
Best Regards,
Huang, Ying
> Thank you!
>
> Ludo’.
next prev parent reply other threads:[~2017-04-01 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 11:13 [PATCH -v2] services: dict.scm: Support more dicod configuration Huang Ying
2017-03-31 22:48 ` bug#26308: " Ludovic Courtès
2017-04-01 11:29 ` Huang, Ying [this message]
2017-04-01 22:12 ` Ludovic Courtès
2017-04-03 2:08 ` huang ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r31cl62m.fsf@163.com \
--to=huang_ying_caritas@163.com \
--cc=26308-done@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.