From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz94Z-00059m-En for guix-patches@gnu.org; Fri, 14 Apr 2017 17:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz94U-0004XD-Ig for guix-patches@gnu.org; Fri, 14 Apr 2017 17:48:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz94U-0004Wp-FN for guix-patches@gnu.org; Fri, 14 Apr 2017 17:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cz94U-0002w9-8V for guix-patches@gnu.org; Fri, 14 Apr 2017 17:48:02 -0400 Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170411225803.2420-1-tumashu@163.com> <20170411225803.2420-2-tumashu@163.com> <87inm9sdcs.fsf@gmail.com> <60b3e50e.AEEAJadpHi4AAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY7oh5@mailjet.com> <67fed3f6.1a3b.15b64e00dfd.Coremail.tumashu@163.com> <87mvbj6w72.fsf@163.com> <4d35676d.AEUAI-hEBJAAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8M5G@mailjet.com> <87zifjm39e.fsf@163.com> Date: Fri, 14 Apr 2017 23:47:17 +0200 In-Reply-To: <87zifjm39e.fsf@163.com> (Feng Shu's message of "Fri, 14 Apr 2017 23:13:01 +0800") Message-ID: <87r30uslui.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Feng Shu Cc: 26454@debbugs.gnu.org Hello Feng Shu, "Feng Shu" skribis: > Sadly, I have found that I can not let exwm work well in guixsd, Could you describe what the problem is? The patch looks good to me, but if you say that the package is actually non-functional, then including it as is may not be very useful, except if these are upstream bugs maybe. >>>From b815a6adb8e8b08bb856e2b9e22ddf31324af101 Mon Sep 17 00:00:00 2001 > From: Feng Shu > Date: Fri, 14 Apr 2017 23:06:15 +0800 > Subject: [PATCH] gnu: add emacs-exwm and emacs-xelb > > * gnu/packages/emacs.scm (emacs-xelb, emacs-exwm): New variables. Before including, please make it two patches. > +(define-public emacs-xelb > + (package > + (name "emacs-xelb") > + (version "0.12.d1d6b6c") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ch11ng/xelb") > + (commit "d1d6b6cb48a6a9562252be20ab49f24708b34335"))) Minor thing: I=E2=80=99d suggest using the regular stanza for the commit/revision number (info "(guix) Version Numbers"). > + (add-after 'unpack 'regenerate-el-files > + (lambda _ Maybe add a comment like =E2=80=9CGenerate .el files from the XML descripti= on of the XCB bindings.=E2=80=9D > + (let ((xcb-proto-xml-path (string-append (assoc-ref %build-= inputs > + "xcb-pr= oto") > + "/share/xcb")) > + (emacs-path (string-append (assoc-ref %build-= inputs > + "emacs") > + "/bin/emacs"))) > + (substitute* "Makefile" > + (("PROTO_PATH :=3D ../xcb-proto/src") > + (string-append "PROTO_PATH :=3D " xcb-proto-xml-path)) > + (("EMACS_BIN :=3D emacs -Q") > + (string-append "EMACS_BIN :=3D " emacs-path " -Q"))) > + (system* "make" "all")) > + #t))))) (zero? (system* "make" "all")) and remove #t. > +(define-public emacs-exwm > + (package > + (name "emacs-exwm") > + (version "0.13.7a5bb11") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ch11ng/exwm") > + (commit "7a5bb1156d07848e465f55fd31f8ec755b52aa01"))) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "0cbaq2ls8pivz4h8hwgn9ldvg16pwlisdf047civvilqiqczw31w"))= )) > + (build-system emacs-build-system) > + (propagated-inputs `(("emacs-xelb" ,emacs-xelb))) > + ;; The following functions or variables is need by emacs-exwm, > + ;; which is not included in 'emacs-minimal'. > + ;; scroll-bar-mode, fringe-mode > + ;; x-display-pixel-width x-display-pixel-height > + (arguments `(#:emacs ,emacs)) > + (home-page "https://github.com/ch11ng/exwm") > + (synopsis "Emacs X Window Manager") > + (description "EXWM (Emacs X Window Manager) is a full-featured > +tiling X window manager for Emacs built on top of XELB.") > + (license license:gpl3+))) Sounds like a lot of fun. :-) Arun: I don=E2=80=99t have anything to add. I think you could at least com= mit the first one. Dunno about exwm proper; maybe it=E2=80=99s not worse than Guile-WM anyway? ;-) Thanks, Ludo=E2=80=99.