[PATCH] gnu: add meson

[PATCH] gnu: add meson

[Corentin Bocquillon]

* gnu/packages/meson.scm (meson.scm) Add meson package.

---
 gnu/packages/meson.scm | 47
+++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47
insertions(+) create mode 100644 gnu/packages/meson.scm

diff --git a/gnu/packages/meson.scm b/gnu/packages/meson.scm
new file mode 100644
index 000000000..1193ab2ae
--- /dev/null
+++ b/gnu/packages/meson.scm
@@ -0,0 +1,47 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2017 Corentin Bocquillon <corentin@nybble.fr>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or
(at +;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages meson)
+  #:use-module ((guix licenses) #:select (asl2.0))
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system python)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages python)
+  #:use-module (gnu packages ninja))
+
+(define-public meson
+  (package
+    (name "meson")
+    (version "0.39.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
"https://github.com/mesonbuild/meson/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+
"1jwgd6sl7zl7h16id3405gwk6vlkk86ggwrp0k47njwkxmryq8d4"))))
+    (build-system python-build-system)
+    (inputs `(("python" ,python)
+              ("ninja", ninja)))
+    (home-page "https://mesonbuild.com/")
+    (synopsis "Meson build system")
+    (description
+     "The meson build system is focused on user-friendliness and
speed.")
+    (license asl2.0)))
-- 
2.12.2

Re: [PATCH] gnu: add meson

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Corentin Bocquillon <corentin@nybble.fr> writes:

> * gnu/packages/meson.scm (meson.scm) Add meson package.

Hello! Thanks for this patch. See comments inline.

Could you send the updated patch to "guix-patches@gnu.org"?

Please also create the patch with `git format-patch` and either send it
as attachment or through `git send-email` so the formatting is
preserved. Thanks in advance!

> ---
>  gnu/packages/meson.scm | 47
> +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
> create mode 100644 gnu/packages/meson.scm

Maybe this could go in "build-tools.scm" instead of creating a new module.

> +(define-public meson
> +  (package
> +    (name "meson")
> +    (version "0.39.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://github.com/mesonbuild/meson/"
> +                                  "archive/" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1jwgd6sl7zl7h16id3405gwk6vlkk86ggwrp0k47njwkxmryq8d4"))))
> +    (build-system python-build-system)
> +    (inputs `(("python" ,python)

"python" is an implicit input when using python-build-system, so that
can be omitted.

> +              ("ninja", ninja)))
> +    (home-page "https://mesonbuild.com/")
> +    (synopsis "Meson build system")
> +    (description
> +     "The meson build system is focused on user-friendliness and
> speed.")

Can you expand on this a little? What makes it different, what are the
use cases etc? It would also be good to see a package that uses it, but
I guess that is coming later ;-)

Looks good otherwise, apart from the formatting!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]