Re: [PATCH] gnu: add meson

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Corentin Bocquillon <corentin@nybble.fr> writes:

> * gnu/packages/meson.scm (meson.scm) Add meson package.

Hello! Thanks for this patch. See comments inline.

Could you send the updated patch to "guix-patches@gnu.org"?

Please also create the patch with `git format-patch` and either send it
as attachment or through `git send-email` so the formatting is
preserved. Thanks in advance!

> ---
>  gnu/packages/meson.scm | 47
> +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
> create mode 100644 gnu/packages/meson.scm

Maybe this could go in "build-tools.scm" instead of creating a new module.

> +(define-public meson
> +  (package
> +    (name "meson")
> +    (version "0.39.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://github.com/mesonbuild/meson/"
> +                                  "archive/" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1jwgd6sl7zl7h16id3405gwk6vlkk86ggwrp0k47njwkxmryq8d4"))))
> +    (build-system python-build-system)
> +    (inputs `(("python" ,python)

"python" is an implicit input when using python-build-system, so that
can be omitted.

> +              ("ninja", ninja)))
> +    (home-page "https://mesonbuild.com/")
> +    (synopsis "Meson build system")
> +    (description
> +     "The meson build system is focused on user-friendliness and
> speed.")

Can you expand on this a little? What makes it different, what are the
use cases etc? It would also be good to see a package that uses it, but
I guess that is coming later ;-)

Looks good otherwise, apart from the formatting!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]