From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5typ-0006zD-HX
	for guix-patches@gnu.org; Wed, 03 May 2017 09:06:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5tyk-0005Cg-Iw
	for guix-patches@gnu.org; Wed, 03 May 2017 09:06:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53877)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d5tyk-0005CW-F8
	for guix-patches@gnu.org; Wed, 03 May 2017 09:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5tyk-0006fv-6j
	for guix-patches@gnu.org; Wed, 03 May 2017 09:06:02 -0400
Subject: bug#26669: [PATCH 7/7] gnu: Add dvdstyler.
Resent-Message-ID: <handler.26669.B26669.149381671325596@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170426.180534.1677459693482729603.post@thomasdanckaert.be>
	<20170426163038.23515-1-thomas.danckaert@gmail.com>
	<20170426163038.23515-6-thomas.danckaert@gmail.com>
Date: Wed, 03 May 2017 15:04:47 +0200
In-Reply-To: <20170426163038.23515-6-thomas.danckaert@gmail.com> (Thomas
	Danckaert's message of "Wed, 26 Apr 2017 18:30:38 +0200")
Message-ID: <87r306rt00.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Thomas Danckaert <thomas.danckaert@gmail.com>
Cc: Thomas Danckaert <post@thomasdanckaert.be>, 26669@debbugs.gnu.org

Thomas Danckaert <thomas.danckaert@gmail.com> skribis:

> From: Thomas Danckaert <post@thomasdanckaert.be>
>
> * gnu/packages/cdrom.scm (dvdstyler): New variable.

[...]

> +    (arguments
> +     `(#:configure-flags (list (string-append "XMLTO=3D"
> +                                              (assoc-ref %build-inputs "=
xmlto")
> +                                              "/bin/xmlto"
> +                                              " --searchpath "
> +                                              (assoc-ref %build-inputs "=
docbook-xsl")
> +                                              "/xml/xsl/docbook-xsl-1.79=
.1/htmlhelp:"
> +                                              (assoc-ref %build-inputs "=
docbook-xml")
> +                                              "/xml/dtd/docbook"))

I'd expect that adding libxml2 as an input would lead to the appropriate
definition of XML_CATALOG_FILES, and thus remove the need for these
#:configure-flags.  Could you try that?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'wrap-program
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (wrap-program (string-append (assoc-ref outputs "out") "/bi=
n/dvdstyler")
> +               `("PATH" ":" prefix
> +                 (,(string-join
> +                    (map (lambda (in) (string-append (assoc-ref inputs i=
n) "/bin"))
> +                                 '("cdrtools" "dvdauthor" "dvd+rw-tools"=
 "ffmpeg"))
                            <-------'
Identation.  :-)

> +                    ":")))))))

Please return #t at the end of the phase.

> +    (license gpl2)))

GPLv2-only, right?

Otherwise LGTM, thanks!

Ludo=E2=80=99.