From: Alex Kost <alezost@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26802@debbugs.gnu.org
Subject: bug#26802: Single source file emacs packages get a ".el.el" extension
Date: Sun, 21 May 2017 12:03:02 +0300 [thread overview]
Message-ID: <87r2zih9a1.fsf@gmail.com> (raw)
In-Reply-To: <0fe6a049.AEUAKMM_QnUAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZHIK3@mailjet.com> (Arun Isaac's message of "Wed, 17 May 2017 22:34:19 +0530")
Arun Isaac (2017-05-17 22:34 +0530) wrote:
[...]
> Patches 3 and 4 are two different ways to solve the double extension
> ".el.el" problem, only one of which we should push.
Actually, I am for both (but for a modified version of the patch 3) :-)
> Patch 3 makes the linter check for the existence of the version number
> somewhere in the source file name. Therefore, if there is no version in
> the file name, the packager will put in a file-name field, thus avoiding
> the double extension problem. However, modifying the linter like this
> will have far-reaching consequences possibly affecting other packages
> which build fine without lint warnings.
Lint warnings are just warnings after all. Having more warnings will
not be a big problem I think.
> I am currently NOT IN FAVOR of this approach.
And I like this approach :-)
As I've just written in another message, I'd like to have a linter that
will check for "name" and "version" to make the store file names
unambiguous. But this is a more general discussion for another topic.
> Patch 4 fixes the problem by just making the emacs-build-system (in
> particular, the `store-file->elisp-source-file' function) more robust,
> and capable of handling file names without a version number. This, I
> think, is the better solution. I am currently IN FAVOR of this approach.
Right, I agree: it's a good fix for the problem, thanks!
> Hopefully, this settles the confusion and ambiguity. :-) WDYT -- Patch
> 3 or 4?
I think patch 4 can be committed now, and patch 3 is for another
discussion.
--
Alex
next prev parent reply other threads:[~2017-05-21 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 12:51 bug#26802: Single source file emacs packages get a ".el.el" extension Arun Isaac
2017-05-09 19:38 ` Alex Kost
2017-05-11 19:19 ` Arun Isaac
2017-05-13 8:54 ` Alex Kost
2017-05-13 16:36 ` Arun Isaac
2017-05-14 17:15 ` Alex Kost
2017-05-15 13:28 ` Arun Isaac
2017-05-16 17:29 ` Alex Kost
2017-05-17 17:04 ` Arun Isaac
2017-05-21 9:03 ` Alex Kost [this message]
2017-05-13 5:23 ` bug#26802: [PATCH 1/3] gnu: emacs-goto-chg: Set source file-name Arun Isaac
2017-05-13 8:55 ` Alex Kost
2017-05-17 16:52 ` bug#26802: [PATCH 1/4] gnu: lint: Fix typo Arun Isaac
2017-05-18 11:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2zih9a1.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=26802@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.