From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1Ja2-0007nL-EG
	for guix-patches@gnu.org; Wed, 28 Mar 2018 18:30:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1JZy-0006E4-6t
	for guix-patches@gnu.org; Wed, 28 Mar 2018 18:30:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49845)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f1JZy-0006E0-3V
	for guix-patches@gnu.org; Wed, 28 Mar 2018 18:30:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1JZx-0003SQ-Sl
	for guix-patches@gnu.org; Wed, 28 Mar 2018 18:30:01 -0400
Subject: [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with
	readline
Resent-Message-ID: <handler.30972.B30972.152227618113245@debbugs.gnu.org>
References: <87k1twkwex.fsf@gnu.org> <87zi2sm33j.fsf@fastmail.com>
From: Roel Janssen <roel@gnu.org>
In-reply-to: <87zi2sm33j.fsf@fastmail.com>
Date: Thu, 29 Mar 2018 00:29:21 +0200
Message-ID: <87r2o3omv2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30972@debbugs.gnu.org


Marius Bakke <mbakke@fastmail.com> writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>  support.
>>
>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>   readline support.
>
> Please mention the changes to [inputs] and [arguments] here.  Also,
> assuming there is an internal copy of zlib, can you remove it with a
> source 'snippet'?

Thanks for the quick response!

Then I'll need to rerun =E2=80=9Cautogen.sh=E2=80=9D to make sure
=E2=80=9Clibsrc/zlib/Makefile.in=E2=80=9D isn't included in the configure p=
hase.  That
in turns needs the following packages added to native-inputs: autoconf,
automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.

Does that justify removing the zlib source directory?  If so, I'll send
the updated patch.  Otherwise, I'll just update the commit message.
Would this be a proper commit message:

gnu: virtuoso-ose: Unbundle zlib and build with readline support.

* gnu/packages/databases.scm (virtuoso-ose):
  [inputs]: Add zlib, and readline;
  [arguments]: Add --without-internal-zlib, and --with-readline.


Thanks for your time.

Kind regards,
Roel Janssen