From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fa0uv-0001NK-3w
	for guix-patches@gnu.org; Mon, 02 Jul 2018 11:39:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fa0ur-0004Ml-Vw
	for guix-patches@gnu.org; Mon, 02 Jul 2018 11:39:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35877)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fa0ur-0004Mf-Ri
	for guix-patches@gnu.org; Mon, 02 Jul 2018 11:39:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fa0ur-0006ew-LD
	for guix-patches@gnu.org; Mon, 02 Jul 2018 11:39:01 -0400
Subject: [bug#32008] [PATCH] gnu: ledger: Skip failing test.
Resent-Message-ID: <handler.32008.B32008.153054592125568@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180629170749.4211-1-arunisaac@systemreboot.net>
Date: Mon, 02 Jul 2018 17:38:31 +0200
In-Reply-To: <20180629170749.4211-1-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Fri, 29 Jun 2018 22:37:49 +0530")
Message-ID: <87r2klejgo.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 32008@debbugs.gnu.org

Hello,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/finance.scm (ledger)[arguments]: Set #:make-flags to skip
> failing test BaselineTest_cmd-org. Replace check phase with the check pha=
se
> from gnu-build-system.
> Replace system* with invoke in build-doc phase.
> Remove #t return from relocate-elisp phase since emacs-generate-autoloads
> already returns #t.
> [home-page]: Switch to HTTPS URI.

It would be nice to make separate patches for unrelated things (for
instance invoke and phase returns have nothing to do with skipping the
test), but otherwise LGTM.

> +       ;; Skip failing tests during the check phase.
> +       #:make-flags (list "ARGS=3D-E BaselineTest_cmd-org")

Do you have more info about the test or an upstream bug report?

Thank you!

Ludo=E2=80=99.