From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faQtD-0003IF-Kw
	for guix-patches@gnu.org; Tue, 03 Jul 2018 15:23:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faQtC-0004Iq-HM
	for guix-patches@gnu.org; Tue, 03 Jul 2018 15:23:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:37776)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1faQtC-0004Im-Df
	for guix-patches@gnu.org; Tue, 03 Jul 2018 15:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faQtC-0007Uh-84
	for guix-patches@gnu.org; Tue, 03 Jul 2018 15:23:02 -0400
Subject: [bug#32008] [PATCH] gnu: ledger: Skip failing test.
Resent-Message-ID: <handler.32008.B32008.153064577628791@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180629170749.4211-1-arunisaac@systemreboot.net>
	<87r2klejgo.fsf@gnu.org> <cu71sckvgsh.fsf@systemreboot.net>
Date: Tue, 03 Jul 2018 21:22:46 +0200
In-Reply-To: <cu71sckvgsh.fsf@systemreboot.net> (Arun Isaac's message of "Tue,
	03 Jul 2018 14:26:30 +0530")
Message-ID: <87r2kkgm49.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 32008@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> It would be nice to make separate patches for unrelated things (for
>> instance invoke and phase returns have nothing to do with skipping the
>> test), but otherwise LGTM.
>
> I bunched these together because the invoke change and home-page change
> were fairly minor things. But, if you insist, I'll push these as three
> separate commits (one for skipping the test, one for invoke/phase
> returns, and one for the home-page change).

Honestly it doesn=E2=80=99t matter much here, but what I like about
one-patch-for-one-thing is that it makes review and bug hunting (when
you later run =E2=80=98git annotate=E2=80=99 to understand what happened) e=
asier.

>>> +       ;; Skip failing tests during the check phase.
>>> +       #:make-flags (list "ARGS=3D-E BaselineTest_cmd-org")
>>
>> Do you have more info about the test or an upstream bug report?
>
> Yes, this is a known upstream bug. It exists even in the latest git
> checkout.
>
> https://github.com/ledger/ledger/issues/550
>
> I also posted to this bug report mentioning our problem in GuixSD. I
> will leave the URI to this bug report in the comments before
> #:make-flags.

Perfect.

> Shall I push with the above mentioned changes?

Sure!

Thank you,
Ludo=E2=80=99.