From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdhpp-0007Ki-Mq for guix-patches@gnu.org; Thu, 12 Jul 2018 16:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdhpm-0001jW-HU for guix-patches@gnu.org; Thu, 12 Jul 2018 16:05:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdhpm-0001ir-3m for guix-patches@gnu.org; Thu, 12 Jul 2018 16:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdhpl-0004fB-LY for guix-patches@gnu.org; Thu, 12 Jul 2018 16:05:01 -0400 Subject: [bug#31999] [PATCH 1/7] gnu: Add volume-key. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180628213237.21625-1-ambrevar@gmail.com> References: <20180628213237.21625-1-ambrevar@gmail.com> Date: Thu, 12 Jul 2018 22:04:38 +0200 Message-ID: <87r2k86x0p.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello! I realize this patch set is incomplete, but will offer some feedback for the next version :-) Pierre Neidhardt writes: > * gnu/package/disk.scm (volume-key): New variable. [...] > + (arguments > + `(#:tests? #f ; Not sure how tests are supposed to pass, even when = run manually. Heh. I tried adding the "bin" output of NSS to get "certutil", but then it failed with: Error creating passphrase-encrypted packet: GPGME: Invalid crypto engine=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 Don't know what's up with that. Perhaps our GPGME package is broken? > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'patch-python.h-path > + (lambda _ > + (let ((python (assoc-ref %build-inputs "python"))) Rather: (lambda* (#:key inputs #:allow-other-keys) (let ((python (assoc-ref inputs "python"))) > + (substitute* "Makefile.in" > + (("/usr/include/python") (string-append python "/includ= e/python"))) > + #t)))))) > + (home-page "https://pagure.io/volume_key") > + (synopsis "Manipulate storage volume encryption keys") > + (description > + "A library for manipulating storage volume encryption keys and stor= ing > +them separately from volumes to handle forgotten passphrases.") Please use complete sentences, e.g. "This package provides a ...". > + (license license:gpl2+))) This is actually GPL2 only, since the source headers specify it without the "or later" clause. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltHtFYACgkQoqBt8qM6 VPr27AgAhHPc5IpqwwnLqzF2ZbttocWoW1Kz844WW3kBLK+1lIdxW23Y5lz8jIkU FDoLDWE9wlUDEKF2STjRnIPkvMFDF8GucXyrwDnAYjez0+5att7sK1GMPGl9NoOY YuQBpp9bpchQiUpfhcADye+YBzxFYF9W7FHhjOAOXTnhl96D+X93RtB/T99vLj3u czHtHtSa/ZfntWtoaGhlmsMlVHHmUi/W9b+wrxrVGXCB8PWs5AG8/yT6Ldz391DW 2aOVbdYeX6iIEyC3bOnAJTHei1v51epo8ys8L46CR0SVCgADmUqijIvJP/5lKN4A JuYQW+VZRrV4MfprKJJYU2cefR2HKA== =tMsp -----END PGP SIGNATURE----- --=-=-=--