[bug#32055] [PATCH 0/2] Add sqlcrush.

[bug#32055] [PATCH 0/2] Add sqlcrush.

[Tobias Geerinckx-Rice]

Guix,

Basically: ttyMyAdmin.

Tested only by poking around in an SQLite database (my reason for 
packaging this).

Kind regards,

T G-R

[bug#32055] [PATCH 1/2] gnu: Add python-pymysql.

[Tobias Geerinckx-Rice]

* gnu/packages/databases.scm (python-pymysql, python2-pymysql): New
public variables.
---
 gnu/packages/databases.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 0f1e47f48..7357dba81 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -84,6 +84,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages popt)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-crypto)
   #:use-module (gnu packages rdf)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
@@ -759,6 +760,34 @@ pictures, sounds, or video.")
                (base32
                 "0w7bwf19wbdd3jjbjv03cnx56qka4801srcbsayk9v792awv7zga"))))))
 
+(define-public python-pymysql
+  (package
+    (name "python-pymysql")
+    (version "0.9.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "PyMySQL" version))
+       (sha256
+        (base32
+         "0gvi63f1zq1bbd30x28kqyx351hal1yc323ckp0mihainb5n1iwy"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-unittest2" ,python-unittest2)))
+    (inputs
+     `(("python-cryptography" ,python-cryptography)))
+    (arguments
+     `(#:tests? #f))                    ; tests expect a running MySQL
+    (home-page "https://github.com/PyMySQL/PyMySQL/")
+    (synopsis "Pure-Python MySQL Driver")
+    (description
+     "PyMySQL is a pure-Python MySQL client library, based on PEP 249.
+Most public APIs are compatible with @command{mysqlclient} and MySQLdb.")
+    (license license:expat)))
+
+(define-public python2-pymysql
+  (package-with-python2 python-pymysql))
+
 (define-public qdbm
   (package
     (name "qdbm")
-- 
2.16.2

[bug#32055] [PATCH 2/2] gnu: Add sqlcrush.

[Tobias Geerinckx-Rice]

* gnu/packages/databases.smc (sqlcrush): New public variable.
---
 gnu/packages/databases.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 7357dba81..e01349c52 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1034,6 +1034,36 @@ for example from a shell script.")
     ;; others (like sparql-query.c) contain a GPLv2+ license header.
     (license (list license:gpl3+))))
 
+(define-public sqlcrush
+  (let ((commit "b5f6868f189566a26eecc78d0f0659813c1aa98a")
+        (revision "1"))
+    (package
+      (name "sqlcrush")
+      (version (git-version "0.1.5" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/coffeeandscripts/sqlcrush.git")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0x3wy40r93p0jv3nbwj9a77wa4ff697d13r0wffmm7q9h3mzsww8"))))
+      (build-system python-build-system)
+      (propagated-inputs
+       `(("python-cryptography" ,python-cryptography)
+         ("python-psycopg2" ,python-psycopg2)
+         ("python-pymysql" ,python-pymysql)
+         ("python-sqlalchemy" ,python-sqlalchemy)))
+      (home-page "https://github.com/coffeeandscripts/sqlcrush")
+      (synopsis "Text console-based database viewer and editor")
+      (description
+       "SQLcrush lets you view and edit a database directly from the text
+console through an ncurses interface.  You can explore each table's structure,
+browse and edit the contents, add and delete entries, all while tracking your
+changes.")
+      (license license:gpl3+)))) ; no headers, see README.md
+
 (define-public sqlite
   (package
    (name "sqlite")
-- 
2.16.2

[bug#32055] [PATCH 2/2] gnu: Add sqlcrush.

[Ludovic Courtès]

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/databases.smc (sqlcrush): New public variable.

[...]

> +      (build-system python-build-system)
> +      (propagated-inputs
> +       `(("python-cryptography" ,python-cryptography)
> +         ("python-psycopg2" ,python-psycopg2)
> +         ("python-pymysql" ,python-pymysql)
> +         ("python-sqlalchemy" ,python-sqlalchemy)))
> +      (home-page "https://github.com/coffeeandscripts/sqlcrush")
> +      (synopsis "Text console-based database viewer and editor")

If it’s an application rather than a library, then perhaps we don’t need
to propagate these?

Otherwise LGTM.

Thanks,
Ludo’.

[bug#32055] [PATCH 1/2] gnu: Add python-pymysql.

[Ludovic Courtès]

Hello Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/databases.scm (python-pymysql, python2-pymysql): New
> public variables.

[...]

> +    (home-page "https://github.com/PyMySQL/PyMySQL/")
> +    (synopsis "Pure-Python MySQL Driver")

Nitpick: "driver" (lowercase).

Otherwise LGTM, thanks!

Ludo’.

bug#32055: [PATCH 0/2] Add sqlcrush.

[Tobias Geerinckx-Rice]

Ludo',

This got buried after the holdays. Thanks for the review!

Ludovic Courtès wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

[...]

>> +      (propagated-inputs
>> +       `(("python-cryptography" ,python-cryptography)
>> +         ("python-psycopg2" ,python-psycopg2)
>> +         ("python-pymysql" ,python-pymysql)
>> +         ("python-sqlalchemy" ,python-sqlalchemy)))

[...]

> If it’s an application rather than a library, then perhaps we 
> don’t need
> to propagate these?

Agreed.

>> +    (synopsis "Pure-Python MySQL Driver")
>
> Nitpick: "driver" (lowercase).
>
> Otherwise LGTM, thanks!

Pushed with the suggested changes as 311f06c et al.

Kind regards,

T G-R