From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6NAd-0003A2-0y for guix-patches@gnu.org; Sat, 29 Sep 2018 17:53:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6NAc-0008DV-Ec for guix-patches@gnu.org; Sat, 29 Sep 2018 17:53:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6NAc-0008DM-Ai for guix-patches@gnu.org; Sat, 29 Sep 2018 17:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6NAc-0002Pc-7v for guix-patches@gnu.org; Sat, 29 Sep 2018 17:53:02 -0400 Subject: [bug#30771] [PATCH] gnu: Add kdenlive. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <1520802749.79146.1299312200.57E1AD5C@webmail.messagingengine.com> <20180922200835.3554-1-boskovits@gmail.com> Date: Sat, 29 Sep 2018 23:52:39 +0200 In-Reply-To: <20180922200835.3554-1-boskovits@gmail.com> ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Sat, 22 Sep 2018 22:08:35 +0200") Message-ID: <87r2hcvumw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: Mark Meyer , 30771@debbugs.gnu.org Hello G=C3=A1bor! G=C3=A1bor Boskovits skribis: > From: Mark Meyer > > * gnu/packages/kde.scm (kdenlive): New variable. > > Co-authored-by: G=C3=A1bor Boskovits > Signed-off-by: G=C3=A1bor Boskovits [...] > + (add-after 'install 'wrap-executable > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (qtquickcontrols (assoc-ref inputs "qtquickcontrol= s")) > + (qtbase (assoc-ref inputs "qtbase")) > + (qtdeclarative (assoc-ref inputs "qtdeclarative")) > + (frei0r (assoc-ref inputs "frei0r-plugins")) > + (qml "/lib/qt5/qml")) > + (wrap-program (string-append out "/bin/kdenlive") > + `("QT_PLUGIN_PATH" ":" prefix > + ,(map (lambda (label) > + (string-append (assoc-ref inputs label) > + "/lib/qt5/plugins/")) > + '("qtbase", "qtsvg"))) > + `("FREI0R_PATH" ":" =3D > + (,(string-append frei0r "/lib/frei0r-1/"))) > + `("QT_QPA_PLATFORM_PLUGIN_PATH" ":" =3D > + (,(string-append qtbase "/lib/qt5/plugins/platforms= "))) > + `("QML2_IMPORT_PATH" ":" prefix > + (,(string-append qtquickcontrols qml) > + ,(string-append qtdeclarative qml)))))))))) Please explicitly return #t. Apart from this very minor issue, it LGTM. Thank you! Ludo=E2=80=99.