From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDcNK-0001dd-UC for guix-patches@gnu.org; Fri, 19 Oct 2018 17:32:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDcNH-000278-Ae for guix-patches@gnu.org; Fri, 19 Oct 2018 17:32:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDcNF-00023x-W4 for guix-patches@gnu.org; Fri, 19 Oct 2018 17:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDcNF-0006bv-Lx for guix-patches@gnu.org; Fri, 19 Oct 2018 17:32:01 -0400 Subject: [bug#33038] [PATCH 3/6] bootstrap: Add %bootstrap-mes. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20181014085857.3863-1-janneke@gnu.org> <20181014085857.3863-3-janneke@gnu.org> Date: Fri, 19 Oct 2018 23:31:34 +0200 In-Reply-To: <20181014085857.3863-3-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sun, 14 Oct 2018 10:58:54 +0200") Message-ID: <87r2gld3nt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jan Nieuwenhuizen Cc: 33038@debbugs.gnu.org Jan Nieuwenhuizen skribis: > * gnu/packages/make-bootstrap.scm (%mes-stripped): New variable. > (%mes-bootstrap-tarball): New variable. > * gnu/packages/bootstrap.scm (%bootstrap-mes): New variable. [...] > +(define %bootstrap-mes > + ;; The initial Mes. Uses binaries from a tarball typically built by > + ;; %MES-BOOTSTRAP-TARBALL. > + (package > + (name "bootstrap-mes") > + (version "0") > + (source #f) > + (build-system trivial-build-system) > + (arguments > + `(#:guile ,%bootstrap-guile > + #:modules ((guix build utils)) > + #:builder > + (let ((out (assoc-ref %outputs "out")) > + (tar (assoc-ref %build-inputs "tar")) > + (xz (assoc-ref %build-inputs "xz")) > + (tarball (assoc-ref %build-inputs "tarball"))) > + (use-modules (guix build utils) > + (ice-9 popen)) Please move the =E2=80=98use-modules=E2=80=99 form to the top level (non-to= p-level =E2=80=98use-modules=E2=80=99 works pretty much by chance). > + (inputs > + `(("tar" ,(search-bootstrap-binary "tar" (%current-system))) > + ("xz" ,(search-bootstrap-binary "xz" (%current-system))) > + ("tarball" ,(bootstrap-origin > + (origin > + (method url-fetch) > + (uri (string-append > + "http://lilypond.org/janneke/mes/" > + (match (%current-system) > + ("x86_64-linux" "mes-stripped-0.18-0.08f04= f5-x86_64-linux.tar.xz") > + ("i686-linux" "mes-stripped-0.18-0.08f04f5= -i686-linux.tar.xz")))) > + (sha256 > + (match (%current-system) > + ("x86_64-linux" > + (base32 > + "14sbcm79ml4rgygxvx1135827g3ggfx1c1vchk77z26y= ibbdw9nh")) > + ("i686-linux" > + (base32 > + "1p116ya9n52852bryh34n7db4mhvi98qifmmwygl7nby= c4dz92jy"))))))))) So these two tarballs were made from this commit, minus the bootstrap.scm changes? It would be nice to maybe make this a separate commit (following the make-bootstrap.scm changes) so that you can state in the commit log which commit was used to build this binary. Besides we can consider hosting these binaries on ftp.gnu.org, under /mes or /guix. > --- a/gnu/packages/mes.scm > +++ b/gnu/packages/mes.scm > @@ -21,7 +21,6 @@ > (define-module (gnu packages mes) > #:use-module (gnu packages) > #:use-module (gnu packages base) > - #:use-module (gnu packages commencement) Indeed =E2=80=98commencement=E2=80=99 should never be used by other package= modules, for reasons having to do with circularity. Otherwise LGTM! Ludo=E2=80=99.