From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPoVe-0005a3-HK for guix-patches@gnu.org; Thu, 22 Nov 2018 07:55:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPoVa-0004Z0-GL for guix-patches@gnu.org; Thu, 22 Nov 2018 07:55:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPoVa-0004Yq-DM for guix-patches@gnu.org; Thu, 22 Nov 2018 07:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPoVa-0004jV-9z for guix-patches@gnu.org; Thu, 22 Nov 2018 07:55:02 -0500 Subject: [bug#33448] [PATCH 2/3] describe: Add json format. Resent-Message-ID: From: Oleg Pykhalov References: <20181121141715.16417-1-go.wigust@gmail.com> <20181121141715.16417-2-go.wigust@gmail.com> <87d0qyru8j.fsf@gnu.org> Date: Thu, 22 Nov 2018 15:54:44 +0300 In-Reply-To: <87d0qyru8j.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 21 Nov 2018 22:33:32 +0100") Message-ID: <87r2fd5l2j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33448@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Almost done with current patch series and only one question. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Oleg Pykhalov skribis: > >> * guix/channels.scm (channel->json): New procedure. >> * guix/scripts/describe.scm (%options): Add 'json' option. >> (display-checkout-info, display-profile-info): Use 'channel->json'. >> * doc/guix.texi (Invoking guix describe): Document this. > > [...] > >> +(define channel->json >> + (match-lambda >> + (($ name url branch commit location) >> + (scm->json-string >> + (list >> + (cons 'name name) >> + (cons 'url url) >> + (cons 'commit commit)))))) > > Since this is not a core feature of channels and add a dependency on > (json), what about moving this procedure to (guix scripts describe)? should be exported in (guix channels) in this case. Is it OK? [=E2=80=A6] Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlv2pxQACgkQFn+OpQAa +pxS0A/9GzghMkmQV2Vlf6vxtl6A4B/J3WmqkufP+IjyebWRJzq4nfslXgyXe94p 4hcCdBwTn9/CHWqz9ug44Fp2AefdF14avbRvqekd3itMcs493gC9331Wnk27fuWS AizseApV0NzcTJFHuGVBplasBgryMH1dzEWKhbnOqtYZZug4+l0izgziu5e+AeXX hqHb7ep/0Q6U1kXIl5skg5qW+Dudd3c+o2xBFSnqGs3DVWqE9PSuigtIbozaWhKP 78E68p0Qob2WDuDQNiMJmb9g+TjLQveO+MGXe7Lj/EH/WgmK3eJBCje3MEWOi7bq 8lPHkV4rEbsBlO3hE4VuNawgDM5195zh5zQyhEjhuqPYNyhkwjsqoh6Ve0+GMB2A O0hfOv8xk1eVCozUxp3dt3hUgk19GWp73YLWJw9eCxoj0oIPrneMArMvTt+SWevt GezsTkJMreHMyxDMgsfuLTnxjNf0me6OThQCKDHwr/EOixlLZ+fmV56dXnN3vAJt ZX6kKB22PDkI1fKWeUHIZ+hgrQCh7E6i+1JR/X5EEXi7bxncxQHhK9XPFOCayjBc mXaDf0EK5wr5SIzok6ksXVr1tmlOdIr+Uy+SNXbx9DkHo78Yr0xSf0qmk3e9Mfz+ zsZt2SJ/uGBqt35fizdHDvZHZqPOQfWwNvJYNmxgrcR6dvhSY5w= =8iHB -----END PGP SIGNATURE----- --=-=-=--