Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).

Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).

[Ludovic Courtès]

Hello!

guix-commits@gnu.org skribis:

> +  (packages (append (list ratpoison i3-wm i3status dmenu ;window managers
> +                          nss-certs                      ;for HTTPS access
> +                          )

[...]

> +  (packages (append (list nvi fdisk
> +                          grub          ; mostly so xrefs to its manual work
> +                          parted        ; partprobe
> +                          )

Please don’t leave hanging parens—we want to teach people the Right Way
to format code.  ;-)

Also, you may be able to remove (srfi srfi-1) imports from these
examples.

Last, make sure the text in guix.texi that explains these examples does
not mention ‘cons*’.

Thanks!

Ludo’.

Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]


> Please don’t leave hanging parens—we want to teach people the Right Way
> to format code.  ;-)

I've always wondered what's the recommendation for closing parentheses after
inline comments.

In general, I refrain from using inline comments so I would do this:

--8<---------------cut here---------------start------------->8---
   (packages (append (list nvi fdisk
                           ;; mostly so xrefs to its manual work:
                           grub          
                           ;; partprobe:
                           parted)
--8<---------------cut here---------------end--------------->8---

> Last, make sure the text in guix.texi that explains these examples does
> not mention ‘cons*’.

My rationale here was that I've switched to "(append (list...))" until the first time we explain
cons*, then I left the cons*.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).

[Ludovic Courtès]

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

>> Please don’t leave hanging parens—we want to teach people the Right Way
>> to format code.  ;-)
>
> I've always wondered what's the recommendation for closing parentheses after
> inline comments.

You mean “margin comments” (to the right)?

> In general, I refrain from using inline comments so I would do this:
>
>    (packages (append (list nvi fdisk
>                            ;; mostly so xrefs to its manual work:
>                            grub          
>                            ;; partprobe:
>                            parted)

That would work as well.  Either way: no hanging parens.  :-)

>> Last, make sure the text in guix.texi that explains these examples does
>> not mention ‘cons*’.
>
> My rationale here was that I've switched to "(append (list...))" until the first time we explain
> cons*, then I left the cons*.

Oh OK, perfect!

Ludo’.

Re: 03/04: gnu: Replace all cons* with beginner-friendly (append (list ...)).

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]


> You mean “margin comments” (to the right)?

Indeed!

Alright, I'll merge then!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]