From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1C2H-0000gb-Cr for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1C29-0001UZ-PZ for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48028) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1C25-0001M3-J7 for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1C25-0005pz-Fm for guix-patches@gnu.org; Tue, 05 Mar 2019 10:31:05 -0500 Subject: [bug#34650] [PATCH 7/7] gnu: Add mailcatcher. Resent-Message-ID: References: <87ftsa24ts.fsf@ambrevar.xyz> <20190228174435.14499-1-mail@ambrevar.xyz> <20190228174435.14499-7-mail@ambrevar.xyz> <87fts2fgxe.fsf@cbaines.net> <87y35tvgav.fsf@ambrevar.xyz> From: Pierre Neidhardt In-reply-to: <87y35tvgav.fsf@ambrevar.xyz> Date: Tue, 05 Mar 2019 11:27:44 +0100 Message-ID: <87r2blvcnz.fsf@atlas.engineer> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 34650@debbugs.gnu.org I've taken all your comments into accounts (hopefully). I did not manage to run the test suite for mailcatcher. I've added a comment explaining what's going on, but I don't know enough Ruby to fix it properly. I've pushed to master. Thanks again for your review! -- Pierre Neidhardt https://ambrevar.xyz/