all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <pierre@atlas.engineer>
To: Christopher Baines <mail@cbaines.net>
Cc: 34650@debbugs.gnu.org
Subject: [bug#34650] [PATCH 7/7] gnu: Add mailcatcher.
Date: Tue, 05 Mar 2019 11:27:44 +0100	[thread overview]
Message-ID: <87r2blvcnz.fsf@atlas.engineer> (raw)
In-Reply-To: <87y35tvgav.fsf@ambrevar.xyz>

I've taken all your comments into accounts (hopefully).
I did not manage to run the test suite for mailcatcher.  I've added a
comment explaining what's going on, but I don't know enough Ruby to fix
it properly.

I've pushed to master.

Thanks again for your review!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

  reply	other threads:[~2019-03-05 15:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 15:17 [bug#34650] [PATCH] ruby-mailcatcher: Draft Pierre Neidhardt
     [not found] ` <handler.34650.B.155110784318701.ack@debbugs.gnu.org>
2019-02-25 15:21   ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-02-25 19:10     ` Christopher Baines
2019-02-26 10:59       ` Pierre Neidhardt
2019-02-28 17:44         ` [bug#34650] [PATCH 1/7] gnu: ruby-rack-protection: Update to 2.0.5 Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 2/7] gnu: Add ruby-tilt Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann Pierre Neidhardt
2019-03-04 21:20             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 4/7] gnu: Add ruby-sinatra Pierre Neidhardt
2019-02-28 17:44           ` [bug#34650] [PATCH 5/7] gnu: Add ruby-thin Pierre Neidhardt
2019-03-04 21:33             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 6/7] gnu: Add ruby-skinny Pierre Neidhardt
2019-03-04 21:43             ` Christopher Baines
2019-02-28 17:44           ` [bug#34650] [PATCH 7/7] gnu: Add mailcatcher Pierre Neidhardt
2019-03-04 21:50             ` Christopher Baines
2019-03-05  9:09               ` Pierre Neidhardt
2019-03-05 10:27                 ` Pierre Neidhardt [this message]
2019-03-05 18:51                 ` Christopher Baines
2019-02-28 17:47         ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-03-04 21:06           ` Christopher Baines
2019-03-05  9:18             ` Pierre Neidhardt
2019-03-05 18:51               ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2blvcnz.fsf@atlas.engineer \
    --to=pierre@atlas.engineer \
    --cc=34650@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.