From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:33112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7kBf-0008RL-I2
	for guix-patches@gnu.org; Sat, 23 Mar 2019 13:12:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7kBe-0004Ya-J8
	for guix-patches@gnu.org; Sat, 23 Mar 2019 13:12:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42210)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h7kBe-0004YQ-DB
	for guix-patches@gnu.org; Sat, 23 Mar 2019 13:12:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7kBe-0000nQ-7D
	for guix-patches@gnu.org; Sat, 23 Mar 2019 13:12:02 -0400
Subject: [bug#34921] [PATCH] gnu: Add adanaxis-mush and adanaxisgpl.
Resent-Message-ID: <handler.34921.B34921.15533611073037@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190319195734.2680-1-kkebreau@posteo.net>
Date: Sat, 23 Mar 2019 18:11:37 +0100
In-Reply-To: <20190319195734.2680-1-kkebreau@posteo.net> (Kei Kebreau's
	message of "Tue, 19 Mar 2019 15:57:34 -0400")
Message-ID: <87r2axv7li.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 34921@debbugs.gnu.org

Hello,

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/games.scm (adanaxis-mush, adanaxisgpl): New variables.

[...]

> +;; Data package for adanaxisgpl.
> +(define adanaxis-mush
> +  (let ((name "adanaxis-mush")
> +        (version "1.1.0"))
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append "http://www.mushware.com/files/"
> +                          name "-" version ".tar.gz"))

There seems to be a consensus that using =E2=80=98name=E2=80=99 to build fi=
le names like
this isn=E2=80=99t great, so I=E2=80=99d suggest not doing it.  :-)

> +       (uri (string-append "http://www.mushware.com/files/"
> +                           name "-" version ".tar.gz"))

Ditto.

> +       (snippet
> +        '(begin
> +           ;; Necessary for building with gcc >=3D4.7.
> +           (substitute* "src/Mushcore/MushcoreSingleton.h"
> +             (("SingletonPtrSet\\(new SingletonType\\);")
> +              "MushcoreSingleton::SingletonPtrSet(new SingletonType);"))
> +           ;; Avoid an "invalid conversion from const char* to char*" er=
ror.
> +           (substitute* "src/Platform/X11/PlatformMiscUtils.cpp"
> +             (("char \\*end, \\*result;")
> +              (string-append "const char *end;"
> +                             "\n"
> +                             "char *result;")))))))

Please return #t.

> +    (license license:gpl2)))

If it=E2=80=99s v2-only, go for it!

Thank you,
Ludo=E2=80=99.