From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: bug#36135: installer wifi password prompt Date: Sat, 08 Jun 2019 22:11:08 +0200 Message-ID: <87r2836dnn.fsf@nckx> References: <20190608151502.5d22d7e8@tachikoma.lepiller.eu> <87zhmr984t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48596) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZhhA-00049r-J4 for bug-guix@gnu.org; Sat, 08 Jun 2019 16:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZhh6-0005tN-KD for bug-guix@gnu.org; Sat, 08 Jun 2019 16:12:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZhh4-0005p0-0U for bug-guix@gnu.org; Sat, 08 Jun 2019 16:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZhh3-0002Zm-Qn for bug-guix@gnu.org; Sat, 08 Jun 2019 16:12:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87zhmr984t.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36135@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Ludovic Court=C3=A8s wrote: > Tobias Geerinckx-Rice skribis: > >> * gnu/installer/newt/wifi.scm (run-wifi-password-page): >> Add an #:INPUT-SHOW-CHECKBOX? to the input page. > > [...] > >> + #:input-show-checkbox? #t)) > > It=E2=80=99s called #:input-hide-checkbox? AFAICS. Yes. See the other patches in this ad-hoc =E2=80=98series=E2=80=99. > You can double-check that it builds without warnings with: > > guix system vm -v2 gnu/system/install.scm Sure, I guess, but could you explain the point of doing so?=20 Reproducibility by others? I don't think patches like these=20 should be pushed with such light testing, and I don't see how this=20 can be tested in a VM. Hence the dusty Dell Latitude mentioned earlier ;-) It smells funny. > Please add a =E2=80=9CPartly fixes =E2=80=A6=E2=80=9D line. This fixes b= oth the=20 > password length > and the password visibility issues since =E2=80=98run-input-page=E2=80=99= will=20 > now use > FLAG-SCROLL. Yah, I didn't merge the bugs for that reason, and because I'm=20 still trying to fix more bugs (well, mainly waiting for dd while=20 doing other stuff, since this can't be tested in a VM=E2=80=A6) Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXPwWXAAKCRANsP+IT1Vt eXsUAP99+t4EyPH6H4WiHpJwnTdj6eLPsFvrJedJBAthSCBbjgEA2yiMUOPt6TQ1 agEKsQ6v/ZIwCTG8WEpvBhFqQ9SA8QE= =wdD/ -----END PGP SIGNATURE----- --=-=-=--