From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45086) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiLKC-0004m7-RL for guix-patches@gnu.org; Tue, 02 Jul 2019 12:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiLKA-0002yZ-2I for guix-patches@gnu.org; Tue, 02 Jul 2019 12:08:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38920) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiLK6-0002vd-I7 for guix-patches@gnu.org; Tue, 02 Jul 2019 12:08:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiLK6-0002sU-B0 for guix-patches@gnu.org; Tue, 02 Jul 2019 12:08:02 -0400 Subject: [bug#36410] [PATCH] gnu: Add screenfetch. Resent-Message-ID: From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) References: <8736ju8rrt.fsf@sdf.lonestar.org> <20190702071850.GA22794@macbook41> Date: Tue, 02 Jul 2019 12:07:31 -0400 In-Reply-To: <20190702071850.GA22794@macbook41> (Efraim Flashner's message of "Tue, 2 Jul 2019 10:18:50 +0300") Message-ID: <87r278to70.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 36410@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi Efraim, Efraim Flashner writes: > If 'install-file' works here then the above 6 lines can be 2, something > like: > (install-file (string-append source "/screenfetch.1") > (string-append %output "/man/man1/")) That's certainly much clearer. Would it make sense to do the same for 'screenfetch-dev', renaming the file after copying it with 'install-file'? Or, should a '#:rename' keyword be added to 'install-file', perhaps? I don't know if it would be a useful pattern or not, but it's an easy addition and I'd be happy to submit a separate patch if there's any interest. > you can use the patch-shebang function here, should help a bit. Thanks, that seems to be just one of many hidden gems in '(guix build utils)'. I should really skim through that whole file at some point, these procedures would definitely make packaging much easier. > Ideally these should wrap the binary rather than being propagated. I'm a bit unsure as to what you mean. Should I patch the screenfetch script to use absolute paths for the binaries of these inputs? I.e. patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'? Regards, Jakob --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0bgUMACgkQ9Qb9Fp2P 2VpvPw//Xb+Hb1XEU4slb5eAB6+kxo6K2ufphsqA8AlfmqrveUzoFPZLGx6fdk5/ p+Q8EmE19tm7Z23zqxlKWAGdf7JNeNcQVsW61nazngcqMFmr1hpH/mZOe8h9MVxE MOpFOMFCkZtto1rIUjvGgeN+ztsIY4ixvNOCbUmSVTo+VU80NRak85O0eqdOniF4 zplC96OJxi8o3CakZX+jVW0XGoY8OQJRkJ4BAD2BXNc/gF3ZOp3ydAaMMClMP0oZ yzs0HiwW9Q/rtem9SaL62MGbsiKEYo8oFRD6JBSvB7fTBROxfhacDGWTH4sNrtoY iKY0aSPfbm/KfSMt3mkcKwLQoSuva5hoHLGJjseewbTs6tvn5VTcyD9kw8mtKQTs 1DMaNqV9/IUwNBnzfV1ntP5j46+q0cz0c2yUhLQyZzyET/SAGCUw9wqvS/lOVwGH 8lS9u3JzXBPP9kE30es83zr0hBX7hD1wLpzZZKTSsDF+qVdCDoGECChlvbyEFHjV XktsGoFsBuMi0N3/39KyuM5As8z2GyPENOz30UoVA+fg/prRdTFITb956pCJ16hr 4trhNzrO/UD7TiBEjZA6Ooh1fZz28ZLC4FB7VTDC9rnbF9G/l/KK73EmdOByzMZW oJdGMGnq82ORWmtDIwRCqz/9SdvPiVc1m/oAY+V4UNFhkY0fZ3c= =o3Lc -----END PGP SIGNATURE----- --=-=-=--