From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36410@debbugs.gnu.org
Subject: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Tue, 02 Jul 2019 12:07:31 -0400 [thread overview]
Message-ID: <87r278to70.fsf@sdf.lonestar.org> (raw)
In-Reply-To: <20190702071850.GA22794@macbook41> (Efraim Flashner's message of "Tue, 2 Jul 2019 10:18:50 +0300")
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
Hi Efraim,
Efraim Flashner <efraim@flashner.co.il> writes:
> If 'install-file' works here then the above 6 lines can be 2, something
> like:
> (install-file (string-append source "/screenfetch.1")
> (string-append %output "/man/man1/"))
That's certainly much clearer. Would it make sense to do the same for
'screenfetch-dev', renaming the file after copying it with
'install-file'? Or, should a '#:rename' keyword be added to
'install-file', perhaps? I don't know if it would be a useful pattern or
not, but it's an easy addition and I'd be happy to submit a separate
patch if there's any interest.
> you can use the patch-shebang function here, should help a bit.
Thanks, that seems to be just one of many hidden gems in '(guix build
utils)'. I should really skim through that whole file at some point,
these procedures would definitely make packaging much easier.
> Ideally these should wrap the binary rather than being propagated.
I'm a bit unsure as to what you mean. Should I patch the screenfetch
script to use absolute paths for the binaries of these inputs? I.e.
patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'?
Regards,
Jakob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-07-02 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 0:42 [bug#36410] [PATCH] gnu: Add screenfetch Jakob L. Kreuze
2019-06-28 5:15 ` swedebugia
2019-06-28 14:00 ` Jakob L. Kreuze
2019-07-02 7:18 ` Efraim Flashner
2019-07-02 16:07 ` Jakob L. Kreuze [this message]
2019-09-05 12:06 ` Efraim Flashner
2019-09-23 16:08 ` bug#36410: " Efraim Flashner
2019-09-28 20:48 ` [bug#36410] " Jakob L. Kreuze
2019-10-05 8:19 ` Jakob L. Kreuze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r278to70.fsf@sdf.lonestar.org \
--to=zerodaysfordays@sdf.lonestar.org \
--cc=36410@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.