From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54593) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMcXC-0003qS-Vn for guix-patches@gnu.org; Mon, 21 Oct 2019 14:36:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMcXB-0006BL-Sf for guix-patches@gnu.org; Mon, 21 Oct 2019 14:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMcXB-0006BE-Pb for guix-patches@gnu.org; Mon, 21 Oct 2019 14:36:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMcXB-0001hq-KG for guix-patches@gnu.org; Mon, 21 Oct 2019 14:36:01 -0400 Subject: [bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants. Resent-Message-ID: From: Jan Nieuwenhuizen References: <9ex2heUi-a_eFy92HaMuh0B33VewNqHzK6r5aayN566rDR-hlo78vAmX0vhMzY2_hzGQRXZvXRYustyKwDqmT2SK-KNEm2azpTeusxKMiv8=@carldong.me> <87imolmblu.fsf@gnu.org> Date: Mon, 21 Oct 2019 20:35:24 +0200 In-Reply-To: (Carl Dong's message of "Mon, 21 Oct 2019 17:49:55 +0000") Message-ID: <87r236ymj7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Carl Dong Cc: "37813@debbugs.gnu.org" <37813@debbugs.gnu.org>, Ludovic =?UTF-8?Q?Court=C3=A8s?= Carl Dong writes: Hi Carl, > Thank you for your thorough review, definitely a lot to learn for me > still :-) You're welcome -- however my patches are no better than yours, I was very happy with its state. >> As a general remark, in GNU we avoid the use the prefix `win' when we >> mean Microsoft Windows. We either use `windows' in full, or `w' (or >> w32). (https://www.gnu.org/prep/standards/html_node/Trademarks.html). >> >> So, what about using `-windows-pthreads' and `with-windows-pthreads', >> throughout? > > Actually, the library itself is called `winpthreads` according to > http://mingw-w64.org/ and as seen in the codebase here: > https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-li= braries/winpthreads/, > is that okay? Ah, I see. That is unfortunate. We would need a maintainer to decide then, I'm CC'ing Ludo'. Personally I would still prefer `windows-pthreads' or `wpthreads'. > I believe I've addressed the rest of the concerns in the patch below, tha= nks > again! Certainly, other than that, LGTM! Thanks a lot for your patch. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com