From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Carl Dong <contact@carldong.me>
Cc: "37813@debbugs.gnu.org" <37813@debbugs.gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants.
Date: Mon, 21 Oct 2019 20:35:24 +0200 [thread overview]
Message-ID: <87r236ymj7.fsf@gnu.org> (raw)
In-Reply-To: <L1wRhWjTmpEwuUIPZmPwoG5YKra-1Icc6dzPMgsS0b5ezV1JF7rdXQ08M6l4DgrAup1zxiOGSExePpjN7ZwrC-Ik4fwNxDQzS7MK5Dpk9ss=@carldong.me> (Carl Dong's message of "Mon, 21 Oct 2019 17:49:55 +0000")
Carl Dong writes:
Hi Carl,
> Thank you for your thorough review, definitely a lot to learn for me
> still :-)
You're welcome -- however my patches are no better than yours, I was
very happy with its state.
>> As a general remark, in GNU we avoid the use the prefix `win' when we
>> mean Microsoft Windows. We either use `windows' in full, or `w' (or
>> w32). (https://www.gnu.org/prep/standards/html_node/Trademarks.html).
>>
>> So, what about using `-windows-pthreads' and `with-windows-pthreads',
>> throughout?
>
> Actually, the library itself is called `winpthreads` according to
> http://mingw-w64.org/ and as seen in the codebase here:
> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-libraries/winpthreads/,
> is that okay?
Ah, I see. That is unfortunate. We would need a maintainer to decide
then, I'm CC'ing Ludo'. Personally I would still prefer
`windows-pthreads' or `wpthreads'.
> I believe I've addressed the rest of the concerns in the patch below, thanks
> again!
Certainly, other than that, LGTM!
Thanks a lot for your patch.
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2019-10-21 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 17:52 [bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants Carl Dong
2019-10-19 7:35 ` Jan (janneke) Nieuwenhuizen
2019-10-21 17:49 ` Carl Dong
2019-10-21 18:35 ` Jan Nieuwenhuizen [this message]
2019-10-21 20:53 ` Ludovic Courtès
2019-10-21 21:37 ` Carl Dong
2019-10-23 13:49 ` bug#37813: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r236ymj7.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=37813@debbugs.gnu.org \
--cc=contact@carldong.me \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.